Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/browser/signin/oauth2_token_service_delegate_android.h

Issue 1509373004: Pass method parameters as JavaParamRef in chrome/browser (part 2). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/oauth2_token_service_delegate_android.h
diff --git a/chrome/browser/signin/oauth2_token_service_delegate_android.h b/chrome/browser/signin/oauth2_token_service_delegate_android.h
index 4bade06d07ccfcc550c424432680ab0cb6d54e7e..dec7930e75abc1c5357549af98a9fa60f120154f 100644
--- a/chrome/browser/signin/oauth2_token_service_delegate_android.h
+++ b/chrome/browser/signin/oauth2_token_service_delegate_android.h
@@ -55,10 +55,11 @@ class OAuth2TokenServiceDelegateAndroid : public OAuth2TokenServiceDelegate {
// Lists account names at the OS level.
std::vector<std::string> GetSystemAccountNames();
- void ValidateAccounts(JNIEnv* env,
- jobject obj,
- jstring current_account,
- jboolean force_notifications);
+ void ValidateAccounts(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ const base::android::JavaParamRef<jstring>& current_account,
+ jboolean force_notifications);
// Takes a the signed in sync account as well as all the other
// android account ids and check the token status of each. If
@@ -70,17 +71,21 @@ class OAuth2TokenServiceDelegateAndroid : public OAuth2TokenServiceDelegate {
// Triggers a notification to all observers of the OAuth2TokenService that a
// refresh token is now available. This may cause observers to retry
// operations that require authentication.
- virtual void FireRefreshTokenAvailableFromJava(JNIEnv* env,
- jobject obj,
- const jstring account_name);
+ virtual void FireRefreshTokenAvailableFromJava(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ const base::android::JavaParamRef<jstring>& account_name);
// Triggers a notification to all observers of the OAuth2TokenService that a
// refresh token is now available.
- virtual void FireRefreshTokenRevokedFromJava(JNIEnv* env,
- jobject obj,
- const jstring account_name);
+ virtual void FireRefreshTokenRevokedFromJava(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ const base::android::JavaParamRef<jstring>& account_name);
// Triggers a notification to all observers of the OAuth2TokenService that all
// refresh tokens have now been loaded.
- virtual void FireRefreshTokensLoadedFromJava(JNIEnv* env, jobject obj);
+ virtual void FireRefreshTokensLoadedFromJava(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
// Overridden from OAuth2TokenService to complete signout of all
// OA2TService aware accounts.

Powered by Google App Engine
This is Rietveld 408576698