Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: chrome/browser/password_manager/account_chooser_dialog_android.cc

Issue 1509373004: Pass method parameters as JavaParamRef in chrome/browser (part 2). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/account_chooser_dialog_android.cc
diff --git a/chrome/browser/password_manager/account_chooser_dialog_android.cc b/chrome/browser/password_manager/account_chooser_dialog_android.cc
index a7b6730de0fe5b6025806e5eeae4b58e8b443ce8..4321e973d88b6bd85bd65da35a1de7a1e837566f 100644
--- a/chrome/browser/password_manager/account_chooser_dialog_android.cc
+++ b/chrome/browser/password_manager/account_chooser_dialog_android.cc
@@ -154,24 +154,30 @@ void AccountChooserDialogAndroid::ShowDialog() {
local_credentials_forms().size(), request_context);
}
-void AccountChooserDialogAndroid::OnCredentialClicked(JNIEnv* env,
- jobject obj,
- jint credential_item,
- jint credential_type) {
+void AccountChooserDialogAndroid::OnCredentialClicked(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ jint credential_item,
+ jint credential_type) {
ChooseCredential(
credential_item,
static_cast<password_manager::CredentialType>(credential_type));
}
-void AccountChooserDialogAndroid::Destroy(JNIEnv* env, jobject obj) {
+void AccountChooserDialogAndroid::Destroy(JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
delete this;
}
-void AccountChooserDialogAndroid::CancelDialog(JNIEnv* env, jobject obj) {
+void AccountChooserDialogAndroid::CancelDialog(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
ChooseCredential(-1, password_manager::CredentialType::CREDENTIAL_TYPE_EMPTY);
}
-void AccountChooserDialogAndroid::OnLinkClicked(JNIEnv* env, jobject obj) {
+void AccountChooserDialogAndroid::OnLinkClicked(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
web_contents_->OpenURL(content::OpenURLParams(
GURL(password_manager::kPasswordManagerAccountDashboardURL),
content::Referrer(), NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_LINK,

Powered by Google App Engine
This is Rietveld 408576698