Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1706)

Unified Diff: chrome/browser/signin/oauth2_token_service_delegate_android.cc

Issue 1509373004: Pass method parameters as JavaParamRef in chrome/browser (part 2). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/oauth2_token_service_delegate_android.cc
diff --git a/chrome/browser/signin/oauth2_token_service_delegate_android.cc b/chrome/browser/signin/oauth2_token_service_delegate_android.cc
index 4bccc15060c18afcf0aed54339561c74f066d61e..da4be91c790c6e811a5cae77cd9fc8f2bb31350b 100644
--- a/chrome/browser/signin/oauth2_token_service_delegate_android.cc
+++ b/chrome/browser/signin/oauth2_token_service_delegate_android.cc
@@ -286,8 +286,8 @@ void OAuth2TokenServiceDelegateAndroid::InvalidateAccessToken(
void OAuth2TokenServiceDelegateAndroid::ValidateAccounts(
JNIEnv* env,
- jobject obj,
- jstring j_current_acc,
+ const JavaParamRef<jobject>& obj,
+ const JavaParamRef<jstring>& j_current_acc,
jboolean j_force_notifications) {
std::string signed_in_account_name;
DVLOG(1) << "OAuth2TokenServiceDelegateAndroid::ValidateAccounts from java";
@@ -436,8 +436,8 @@ bool OAuth2TokenServiceDelegateAndroid::ValidateAccounts(
void OAuth2TokenServiceDelegateAndroid::FireRefreshTokenAvailableFromJava(
JNIEnv* env,
- jobject obj,
- const jstring account_name) {
+ const JavaParamRef<jobject>& obj,
+ const JavaParamRef<jstring>& account_name) {
std::string account_id =
MapAccountNameToAccountId(ConvertJavaStringToUTF8(env, account_name));
// Notify native observers.
@@ -463,8 +463,8 @@ void OAuth2TokenServiceDelegateAndroid::FireRefreshTokenAvailable(
void OAuth2TokenServiceDelegateAndroid::FireRefreshTokenRevokedFromJava(
JNIEnv* env,
- jobject obj,
- const jstring account_name) {
+ const JavaParamRef<jobject>& obj,
+ const JavaParamRef<jstring>& account_name) {
std::string account_id =
MapAccountNameToAccountId(ConvertJavaStringToUTF8(env, account_name));
// Notify native observers.
@@ -490,7 +490,7 @@ void OAuth2TokenServiceDelegateAndroid::FireRefreshTokenRevoked(
void OAuth2TokenServiceDelegateAndroid::FireRefreshTokensLoadedFromJava(
JNIEnv* env,
- jobject obj) {
+ const JavaParamRef<jobject>& obj) {
// Notify native observers.
FireRefreshTokensLoaded();
}

Powered by Google App Engine
This is Rietveld 408576698