Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 1509323003: Fix Chrome 47 test suppressions and invalid @DontInline directive (Closed)

Created:
5 years ago by Alan Knight
Modified:
5 years ago
Reviewers:
Johnni Winther, terry, sra1
CC:
reviews_dartlang.org, Johnni Winther
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix Chrome 47 test suppressions and invalid @DontInline directive BUG= Committed: https://github.com/dart-lang/sdk/commit/44d82ebc43b952ca5fafb65ca94bc7afbce817f5

Patch Set 1 #

Patch Set 2 : Add the HTML tests that were Pass/runtime error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -27 lines) Patch
M tests/co19/co19-dart2js.status View 13 chunks +24 lines, -22 lines 0 comments Download
M tests/compiler/dart2js_extra/mirror_invalid_invoke2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_extra/mirror_invalid_invoke3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_extra/mirror_invalid_invoke_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/html.status View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Alan Knight
TBR All bots are now on Chrome 47, remove the Pass option for related tests. ...
5 years ago (2015-12-09 18:30:58 UTC) #2
Alan Knight
Committed patchset #2 (id:20001) manually as 44d82ebc43b952ca5fafb65ca94bc7afbce817f5 (presubmit successful).
5 years ago (2015-12-09 18:32:39 UTC) #4
Johnni Winther
5 years ago (2015-12-10 08:56:34 UTC) #6
Message was sent while issue was closed.
dart2js_extra changes LGTM! Thanks for fixing it!

Powered by Google App Engine
This is Rietveld 408576698