Report compile-time error on disallowed metadata values.

Report compile-time error on disallowed metadata values.

Closes #14548

R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/7716ef5da115d8911f42c4c9954ab98749a383fa

[Johnni Winther, 2015-12-09 13:30:40]

johnniwinther@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2015-12-09 14:07:30]

LGTM.

https://codereview.chromium.org/1510863004/diff/1/pkg/compiler/lib/src/diagno...
File pkg/compiler/lib/src/diagnostics/messages.dart (right):

https://codereview.chromium.org/1510863004/diff/1/pkg/compiler/lib/src/diagno...
pkg/compiler/lib/src/diagnostics/messages.dart:2873: "A metadata must be either
a reference to a compile-time constant "
'A metadata annotation' or 'Metadata'.

https://codereview.chromium.org/1510863004/diff/1/pkg/compiler/lib/src/diagno...
pkg/compiler/lib/src/diagnostics/messages.dart:2884: "A metadata call to a
constant constructor cannot use type "
'Metadata annotation using a constant ...'

https://codereview.chromium.org/1510863004/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/resolution.dart (right):

https://codereview.chromium.org/1510863004/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/resolution.dart:1075: // Enforce the unnecessary
syntactic restriction that disallows type
Maybe file a bug against the specification instead and simply say here: 'Const
constructor calls cannot have type arguments. // TODO(___): remove this
restriction.

https://codereview.chromium.org/1510863004/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/resolution.dart:1085: default:
Consider asserting what can reach here.

[Johnni Winther, 2015-12-09 14:43:44]

https://codereview.chromium.org/1510863004/diff/1/pkg/compiler/lib/src/diagno...
File pkg/compiler/lib/src/diagnostics/messages.dart (right):

https://codereview.chromium.org/1510863004/diff/1/pkg/compiler/lib/src/diagno...
pkg/compiler/lib/src/diagnostics/messages.dart:2873: "A metadata must be either
a reference to a compile-time constant "
On 2015/12/09 14:07:29, karlklose wrote:
> 'A metadata annotation' or 'Metadata'.

Done.

https://codereview.chromium.org/1510863004/diff/1/pkg/compiler/lib/src/diagno...
pkg/compiler/lib/src/diagnostics/messages.dart:2884: "A metadata call to a
constant constructor cannot use type "
On 2015/12/09 14:07:29, karlklose wrote:
> 'Metadata annotation using a constant ...'

Done.

https://codereview.chromium.org/1510863004/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/resolution.dart (right):

https://codereview.chromium.org/1510863004/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/resolution.dart:1075: // Enforce the unnecessary
syntactic restriction that disallows type
On 2015/12/09 14:07:29, karlklose wrote:
> Maybe file a bug against the specification instead and simply say here: 'Const
> constructor calls cannot have type arguments. // TODO(___): remove this
> restriction.

Done.

https://codereview.chromium.org/1510863004/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/resolution.dart:1085: default:
On 2015/12/09 14:07:29, karlklose wrote:
> Consider asserting what can reach here.

Everything else (the kind is an enum).

[Johnni Winther, 2015-12-09 14:48:49]

Description was changed from

==========
Report compile-time error on disallowed metadata values.

Closes #14548
==========

to

==========
Report compile-time error on disallowed metadata values.

Closes #14548

R=karlklose@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7716ef5da115d8911f42c4c9954ab98749a383fa
==========

[Johnni Winther, 2015-12-09 14:48:50]

Committed patchset #2 (id:20001) manually as
7716ef5da115d8911f42c4c9954ab98749a383fa (presubmit successful).