Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1509263002: Generic method subtyping. (Closed)

Created:
5 years ago by Leaf
Modified:
5 years ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org, Brian Wilkerson
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+407 lines, -170 lines) Patch
M pkg/analyzer/lib/src/generated/element.dart View 1 2 3 chunks +24 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 1 5 chunks +102 lines, -9 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/type_system_test.dart View 1 17 chunks +269 lines, -154 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Leaf
5 years ago (2015-12-08 21:39:32 UTC) #2
Jennifer Messerly
LGTM! https://codereview.chromium.org/1509263002/diff/20001/pkg/analyzer/lib/src/generated/element.dart File pkg/analyzer/lib/src/generated/element.dart (right): https://codereview.chromium.org/1509263002/diff/20001/pkg/analyzer/lib/src/generated/element.dart#newcode5091 pkg/analyzer/lib/src/generated/element.dart:5091: if (!(pThis.bound?.substitute2(instantiateTypeArgs, variablesThis) == super trivial :) but ...
5 years ago (2015-12-08 22:30:47 UTC) #3
Leaf
https://codereview.chromium.org/1509263002/diff/20001/pkg/analyzer/lib/src/generated/element.dart File pkg/analyzer/lib/src/generated/element.dart (right): https://codereview.chromium.org/1509263002/diff/20001/pkg/analyzer/lib/src/generated/element.dart#newcode5091 pkg/analyzer/lib/src/generated/element.dart:5091: if (!(pThis.bound?.substitute2(instantiateTypeArgs, variablesThis) == On 2015/12/08 22:30:47, John Messerly ...
5 years ago (2015-12-08 22:51:50 UTC) #4
Leaf
5 years ago (2015-12-08 22:56:54 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
9ea88b3e55e9408ef9086f338ecb48f61cd453ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698