Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: pkg/analyzer/test/src/task/strong/checker_test.dart

Issue 1509263002: Generic method subtyping. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/generated/type_system_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/task/strong/checker_test.dart
diff --git a/pkg/analyzer/test/src/task/strong/checker_test.dart b/pkg/analyzer/test/src/task/strong/checker_test.dart
index 1622cbc155e63b79162c038132ff9de0b818c4f1..4030043d43d9a5d3a9109c54f0f78c3179e5124e 100644
--- a/pkg/analyzer/test/src/task/strong/checker_test.dart
+++ b/pkg/analyzer/test/src/task/strong/checker_test.dart
@@ -1376,7 +1376,6 @@ void main() {
/*=S*/ then/*<S>*/(/*=S*/ onValue(T t)) => null;
}
- // These work because they're exactly equal FunctionTypes
class DerivedFuture<T> extends Future<T> {
/*=S*/ then/*<S>*/(/*=S*/ onValue(T t)) => null;
}
@@ -1385,13 +1384,12 @@ void main() {
/*=B*/ then/*<B>*/(/*=B*/ onValue(A a)) => null;
}
- // These don't work but should.
class DerivedFuture3<T> extends Future<T> {
- /*=/*severe:INVALID_METHOD_OVERRIDE should be pass*/S*/ then/*<S>*/(Object onValue(T t)) => null;
+ /*=S*/ then/*<S>*/(Object onValue(T t)) => null;
}
class DerivedFuture4<A> extends Future<A> {
- /*=/*severe:INVALID_METHOD_OVERRIDE should be pass*/B*/ then/*<B>*/(Object onValue(A a)) => null;
+ /*=B*/ then/*<B>*/(Object onValue(A a)) => null;
}
'''
});
« no previous file with comments | « pkg/analyzer/test/generated/type_system_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698