Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Issue 1509193007: Android: Fix Details link in Origin Info bubble not showing for some sites (Closed)

Created:
5 years ago by tsergeant
Modified:
5 years ago
Reviewers:
Ted C
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Fix Details link in Origin Info bubble not showing for some sites The change to classify mixed content and SHA-1 certificates as insecure meant that a details link would not appear for these sites. BUG=568401 Committed: https://crrev.com/961fa695c86a06921d3179dc80a9814be6461067 Cr-Commit-Position: refs/heads/master@{#364499}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
tsergeant
Hi, Ted, please take a look!
5 years ago (2015-12-10 06:00:55 UTC) #2
Ted C
lgtm
5 years ago (2015-12-10 21:11:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509193007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509193007/1
5 years ago (2015-12-10 22:06:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 22:15:34 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-10 22:16:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/961fa695c86a06921d3179dc80a9814be6461067
Cr-Commit-Position: refs/heads/master@{#364499}

Powered by Google App Engine
This is Rietveld 408576698