Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4299)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java

Issue 1509193007: Android: Fix Details link in Origin Info bubble not showing for some sites (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java b/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
index c2f1e5de365e85b7c88bf9b9f3f2133d3cdcf03d..8b298c8b03fee41646c022e9c0ce5d7da97084ba 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
@@ -483,7 +483,10 @@ public class WebsiteSettingsPopup implements OnClickListener {
* HTTPS connections.
*/
private boolean isConnectionDetailsLinkVisible() {
- return !mIsInternalPage && mSecurityLevel != ConnectionSecurityLevel.NONE;
+ // TODO(tsergeant): If this logic gets any more complicated from additional deprecations,
+ // change it to use something like |SchemeIsCryptographic|.
+ return !mIsInternalPage && (mSecurityLevel != ConnectionSecurityLevel.NONE
+ || mPassiveMixedContentPresent || mDeprecatedSHA1Present);
}
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698