Lazily load API schemas from resource files and convert all APIs to features

chrome/renderer/extensions/api_definitions_natives.cc

Index: chrome/renderer/extensions/api_definitions_natives.cc
diff --git a/chrome/renderer/extensions/api_definitions_natives.cc b/chrome/renderer/extensions/api_definitions_natives.cc
index 6004c7ae0c0de8c698454c75325f38170d5c2c15..e0845315fd7ab1c11dd6b3084aec42b2e7f9f2cb 100644
--- a/chrome/renderer/extensions/api_definitions_natives.cc
+++ b/chrome/renderer/extensions/api_definitions_natives.cc
@@ -6,7 +6,7 @@
 
 #include <algorithm>
 
-#include "chrome/common/extensions/api/extension_api.h"
+#include "chrome/common/extensions/features/base_feature_provider.h"
 
 namespace {
 const char kInvalidExtensionNamespace[] = "Invalid extension namespace";
@@ -25,8 +25,15 @@ ApiDefinitionsNatives::ApiDefinitionsNatives(Dispatcher* dispatcher,
 
 v8::Handle<v8::Value> ApiDefinitionsNatives::GetExtensionAPIDefinitions(
     const v8::Arguments& args) {
-  return dispatcher()->v8_schema_registry()->GetSchemas(
-      ExtensionAPI::GetSharedInstance()->GetAllAPINames());
+  std::vector<std::string> apis;
+  const std::vector<std::string>& feature_names =

[not at google - send to devlin, 2013/05/30 16:38:52]

bleh. this function is going to get messy - and I can't think of a way to
efficiently share the logic with the similar stuff in dispatcher.cc. just copy
it across I guess.

note that this used in two places:

test_custom_bindings.js - and it filters by available things anyway, so we can
just implement that here (simpler, and the only way this will work without the
parent I think)

web_view_exprimental.js - which uses it *incorrectly* and should use the schema
registry function.

To be honest we should actually move this to a test_natives.cc file so make that
explicit, but for now we could rename it GetExtensionAPIDefinitionsForTest so
that the webview thing doesn't happen again.

[cduvall, 2013/06/12 01:22:19]

I renamed to GetExtensionAPIDefinitionsForTest. I didn't find it being used
anywhere in web_view_experimental.js, so maybe that has already been fixed.

[not at google - send to devlin, 2013/06/12 22:34:18]

Thanks. Yeah I got the webview people to fix that separately.

+      BaseFeatureProvider::GetByName("api")->GetAllFeatureNames();
+  for (std::vector<std::string>::const_iterator i = feature_names.begin();
+       i != feature_names.end(); ++i) {
+    if (!BaseFeatureProvider::GetByName("api")->GetFeature(*i)->HasParent())
+      apis.push_back(*i);
+  }
+  return dispatcher()->v8_schema_registry()->GetSchemas(apis);
 }
 
 }  // namespace extensions