chrome/common/extensions/permissions/permission_set.cc - Issue 15091002: Lazily load API schemas from resource files and convert all APIs to features

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/permission_set.cc

Issue 15091002: Lazily load API schemas from resource files and convert all APIs to features (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more comments and fixed tests Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/features/base_feature_provider.cc ('K') | « chrome/common/extensions/manifest.cc ('k') | chrome/renderer/extensions/api_definitions_natives.cc » ('j') | chrome/renderer/extensions/api_definitions_natives.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/permission_set.cc

diff --git a/chrome/common/extensions/permissions/permission_set.cc b/chrome/common/extensions/permissions/permission_set.cc

index a6467aaf27b0dbfcebdb034336c53cb84289d410..1418cc3d2d35c7473f99dc0264e8b0d1961dbeb1 100644

--- a/chrome/common/extensions/permissions/permission_set.cc

+++ b/chrome/common/extensions/permissions/permission_set.cc

@@ -38,19 +38,12 @@ bool RcdBetterThan(const std::string& a, const std::string& b) {

// Names of API modules that can be used without listing it in the

// permissions section of the manifest.

const char* kNonPermissionModuleNames[] = {

- "browserAction",

- "commands",

"devtools",

"events",

"extension",

"i18n",

- "omnibox",

- "pageAction",

- "pageActions",

- "pageLauncher",

"permissions",

"runtime",

- "scriptBadge",

"tabs",

"test",

"types",