Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7301)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/extensions/manifest.cc

Issue 15091002: Lazily load API schemas from resource files and convert all APIs to features (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/common/extensions/features/simple_feature.cc ('K') | « chrome/common/extensions/features/simple_feature.cc ('k') | chrome/common/extensions/permissions/permission_set.cc » ('j') | chrome/renderer/extensions/api_definitions_natives.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/manifest.cc
diff --git a/chrome/common/extensions/manifest.cc b/chrome/common/extensions/manifest.cc
index b57e16df0d328e6b24b1479d8d803edbbda22da2..a02bb53e69d7158bb7ce8fe6b00c0ba9ab1307d3 100644
--- a/chrome/common/extensions/manifest.cc
+++ b/chrome/common/extensions/manifest.cc
@@ -142,8 +142,8 @@ bool Manifest::ValidateManifest(
// checking to let developers know when they screw up.
FeatureProvider* provider = BaseFeatureProvider::GetByName("manifest");
- std::set<std::string> feature_names = provider->GetAllFeatureNames();
- for (std::set<std::string>::iterator feature_name = feature_names.begin();
+ std::vector<std::string> feature_names = provider->GetAllFeatureNames();
not at google - send to devlin 2013/05/24 19:09:18 also const&
cduvall 2013/05/30 00:50:51 Done.
+ for (std::vector<std::string>::iterator feature_name = feature_names.begin();
feature_name != feature_names.end(); ++feature_name) {
// Use Get instead of HasKey because the former uses path expansion.
if (!value_->Get(*feature_name, NULL))
« chrome/common/extensions/features/simple_feature.cc ('K') | « chrome/common/extensions/features/simple_feature.cc ('k') | chrome/common/extensions/permissions/permission_set.cc » ('j') | chrome/renderer/extensions/api_definitions_natives.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698