Lazily load API schemas from resource files and convert all APIs to features

chrome/common/extensions/manifest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/manifest.h"
 
 #include "base/basictypes.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/stringprintf.h"
@@ skipping 124 matching lines @@
     return false;
   }
 
   // Check every feature to see if its in the manifest. Note that this means
   // we will ignore keys that are not features; we do this for forward
   // compatibility.
   // TODO(aa): Consider having an error here in the case of strict error
   // checking to let developers know when they screw up.
 
   FeatureProvider* provider = BaseFeatureProvider::GetByName("manifest");
-  std::set<std::string> feature_names = provider->GetAllFeatureNames();
-  for (std::set<std::string>::iterator feature_name = feature_names.begin();
+  std::vector<std::string> feature_names = provider->GetAllFeatureNames();

[not at google - send to devlin, 2013/05/24 19:09:18]

also const&

[cduvall, 2013/05/30 00:50:51]

Done.

+  for (std::vector<std::string>::iterator feature_name = feature_names.begin();
        feature_name != feature_names.end(); ++feature_name) {
     // Use Get instead of HasKey because the former uses path expansion.
     if (!value_->Get(*feature_name, NULL))
       continue;
 
     Feature* feature = provider->GetFeature(*feature_name);
     Feature::Availability result = feature->IsAvailableToManifest(
         extension_id_, type_, Feature::ConvertLocation(location_),
         GetManifestVersion());
     if (!result.is_available())
@@ skipping 95 matching lines @@
       BaseFeatureProvider::GetByName("manifest")->GetFeature(key);
   if (!feature)
     return true;
 
   return feature->IsAvailableToManifest(
       extension_id_, type_, Feature::ConvertLocation(location_),
       GetManifestVersion()).is_available();
 }
 
 }  // namespace extensions