chrome/renderer/extensions/api_definitions_natives.cc - Issue 15091002: Lazily load API schemas from resource files and convert all APIs to features

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/api_definitions_natives.cc

Issue 15091002: Lazily load API schemas from resource files and convert all APIs to features (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: optimize and "parent" property Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/features/simple_feature.cc ('K') | « chrome/common/extensions/manifest.cc ('k') | chrome/renderer/extensions/dispatcher.cc » ('j') | chrome/renderer/extensions/dispatcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/api_definitions_natives.cc

diff --git a/chrome/renderer/extensions/api_definitions_natives.cc b/chrome/renderer/extensions/api_definitions_natives.cc

index 6004c7ae0c0de8c698454c75325f38170d5c2c15..8de64eb8f79a4dfee7094c6cf7d77a323fb4a508 100644

--- a/chrome/renderer/extensions/api_definitions_natives.cc

+++ b/chrome/renderer/extensions/api_definitions_natives.cc

@@ -6,7 +6,7 @@

#include <algorithm>

-#include "chrome/common/extensions/api/extension_api.h"

+#include "chrome/common/extensions/features/base_feature_provider.h"

namespace {

const char kInvalidExtensionNamespace[] = "Invalid extension namespace";

@@ -26,7 +26,7 @@ ApiDefinitionsNatives::ApiDefinitionsNatives(Dispatcher* dispatcher,

v8::Handle<v8::Value> ApiDefinitionsNatives::GetExtensionAPIDefinitions(

const v8::Arguments& args) {

return dispatcher()->v8_schema_registry()->GetSchemas(

- ExtensionAPI::GetSharedInstance()->GetAllAPINames());

+ BaseFeatureProvider::GetByName("api")->GetAllTopLevelFeatureNames());

}

} // namespace extensions