chrome/common/extensions/features/api_feature.h - Issue 15091002: Lazily load API schemas from resource files and convert all APIs to features

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/features/api_feature.h

Issue 15091002: Lazily load API schemas from resource files and convert all APIs to features (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: optimize and "parent" property Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/extension_api.cc ('K') | « chrome/common/extensions/api/extension_api_unittest.cc ('k') | chrome/common/extensions/features/api_feature.cc » ('j') | chrome/common/extensions/features/base_feature_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/features/api_feature.h

diff --git a/chrome/common/extensions/features/api_feature.h b/chrome/common/extensions/features/api_feature.h

index edd58d1b7d429b61b43210e83b7ad4bb23c73b53..662eecb95c6e097cb66700547ab9b2154bcb3c8a 100644

--- a/chrome/common/extensions/features/api_feature.h

+++ b/chrome/common/extensions/features/api_feature.h

@@ -15,11 +15,13 @@ class APIFeature : public SimpleFeature {

virtual ~APIFeature();

virtual bool IsInternal() const OVERRIDE;

+ virtual bool HasParent() const OVERRIDE;

not at google - send to devlin 2013/05/23 00:09:40 I don't see a reason why this needs to be restrict

cduvall 2013/05/24 03:13:49 Done.

virtual std::string Parse(const DictionaryValue* value) OVERRIDE;

private:

bool internal_;

+ bool has_parent_;

};

} // extensions