Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: chrome/common/extensions/api/extension_api_unittest.cc

Issue 15091002: Lazily load API schemas from resource files and convert all APIs to features (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: optimize and "parent" property Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/extension_api_unittest.cc
diff --git a/chrome/common/extensions/api/extension_api_unittest.cc b/chrome/common/extensions/api/extension_api_unittest.cc
index 0047d5677b85813bb3c136ada5770dd5ceeaeb67..02e9c2ee4dd93af5b7796bec10aaa666eee85b43 100644
--- a/chrome/common/extensions/api/extension_api_unittest.cc
+++ b/chrome/common/extensions/api/extension_api_unittest.cc
@@ -209,7 +209,7 @@ TEST(ExtensionAPI, APIFeatures) {
for (base::DictionaryValue::Iterator iter(*value); !iter.IsAtEnd();
iter.Advance()) {
if (iter.key().find(".") == std::string::npos)
- api.RegisterSchema(iter.key(), "");
+ api.RegisterSchemaResource(iter.key(), 0);
}
EXPECT_EQ(test_data[i].expect_is_available,
@@ -261,7 +261,7 @@ TEST(ExtensionAPI, IsAnyFeatureAvailableToContext) {
for (base::DictionaryValue::Iterator iter(*value); !iter.IsAtEnd();
iter.Advance()) {
if (iter.key().find(".") == std::string::npos)
- api.RegisterSchema(iter.key(), "");
+ api.RegisterSchemaResource(iter.key(), 0);
}
EXPECT_EQ(test_data[i].expect_is_available,
@@ -622,7 +622,8 @@ TEST(ExtensionAPITest, TypesHaveNamespace) {
<< "Failed to load: " << manifest_path.value();
ExtensionAPI api;
- api.RegisterSchema("test.foo", manifest_str);
+ // TODO(cduvall): MAKE THIS WORK
+ api.RegisterSchemaResource("test.foo", 0);
const base::DictionaryValue* schema = api.GetSchema("test.foo");

Powered by Google App Engine
This is Rietveld 408576698