Lazily load API schemas from resource files and convert all APIs to features

chrome/common/extensions/api/extension_api_unittest.cc

Index: chrome/common/extensions/api/extension_api_unittest.cc
diff --git a/chrome/common/extensions/api/extension_api_unittest.cc b/chrome/common/extensions/api/extension_api_unittest.cc
index 0047d5677b85813bb3c136ada5770dd5ceeaeb67..02e9c2ee4dd93af5b7796bec10aaa666eee85b43 100644
--- a/chrome/common/extensions/api/extension_api_unittest.cc
+++ b/chrome/common/extensions/api/extension_api_unittest.cc
@@ -209,7 +209,7 @@ TEST(ExtensionAPI, APIFeatures) {
     for (base::DictionaryValue::Iterator iter(*value); !iter.IsAtEnd();
          iter.Advance()) {
       if (iter.key().find(".") == std::string::npos)
-        api.RegisterSchema(iter.key(), "");
+        api.RegisterSchemaResource(iter.key(), 0);

[not at google - send to devlin, 2013/05/20 17:19:04]

what does this do?

[cduvall, 2013/05/22 03:19:56]

Registers a dummy schema resource. I'm still fixing up these tests.

     }
 
     EXPECT_EQ(test_data[i].expect_is_available,
@@ -261,7 +261,7 @@ TEST(ExtensionAPI, IsAnyFeatureAvailableToContext) {
     for (base::DictionaryValue::Iterator iter(*value); !iter.IsAtEnd();
          iter.Advance()) {
       if (iter.key().find(".") == std::string::npos)
-        api.RegisterSchema(iter.key(), "");
+        api.RegisterSchemaResource(iter.key(), 0);
     }
 
     EXPECT_EQ(test_data[i].expect_is_available,
@@ -622,7 +622,8 @@ TEST(ExtensionAPITest, TypesHaveNamespace) {
       << "Failed to load: " << manifest_path.value();
 
   ExtensionAPI api;
-  api.RegisterSchema("test.foo", manifest_str);
+  // TODO(cduvall): MAKE THIS WORK

[cduvall, 2013/05/17 03:09:30]

Still fixing the unit tests.

+  api.RegisterSchemaResource("test.foo", 0);
 
   const base::DictionaryValue* schema = api.GetSchema("test.foo");