Lazily load API schemas from resource files and convert all APIs to features

chrome/common/extensions/api/extension_api_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/api/extension_api.h"
 
 #include <string>
 #include <vector>
 
 #include "base/file_util.h"
@@ skipping 191 matching lines @@
   scoped_ptr<base::DictionaryValue> value(static_cast<DictionaryValue*>(
       base::JSONReader::Read(api_features_str)));
   BaseFeatureProvider api_feature_provider(*value, CreateAPIFeature);
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_data); ++i) {
     ExtensionAPI api;
     api.RegisterDependencyProvider("api", &api_feature_provider);
     for (base::DictionaryValue::Iterator iter(*value); !iter.IsAtEnd();
          iter.Advance()) {
       if (iter.key().find(".") == std::string::npos)
-        api.RegisterSchema(iter.key(), "");
+        api.RegisterSchemaResource(iter.key(), 0);

[not at google - send to devlin, 2013/05/20 17:19:04]

what does this do?

[cduvall, 2013/05/22 03:19:56]

Registers a dummy schema resource. I'm still fixing up these tests.

     }
 
     EXPECT_EQ(test_data[i].expect_is_available,
               api.IsAvailable(test_data[i].api_full_name,
                               NULL,
                               test_data[i].context,
                               test_data[i].url).is_available()) << i;
   }
 }
 
@@ skipping 31 matching lines @@
   scoped_ptr<base::DictionaryValue> value(static_cast<DictionaryValue*>(
       base::JSONReader::Read(api_features_str)));
   BaseFeatureProvider api_feature_provider(*value, CreateAPIFeature);
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_data); ++i) {
     ExtensionAPI api;
     api.RegisterDependencyProvider("api", &api_feature_provider);
     for (base::DictionaryValue::Iterator iter(*value); !iter.IsAtEnd();
          iter.Advance()) {
       if (iter.key().find(".") == std::string::npos)
-        api.RegisterSchema(iter.key(), "");
+        api.RegisterSchemaResource(iter.key(), 0);
     }
 
     EXPECT_EQ(test_data[i].expect_is_available,
               api.IsAnyFeatureAvailableToContext(test_data[i].api_full_name,
                                                  test_data[i].context,
                                                  test_data[i].url)) << i;
   }
 }
 
 TEST(ExtensionAPITest, LazyGetSchema) {
@@ skipping 340 matching lines @@
   PathService::Get(chrome::DIR_TEST_DATA, &manifest_path);
   manifest_path = manifest_path.AppendASCII("extensions")
       .AppendASCII("extension_api_unittest")
       .AppendASCII("types_have_namespace.json");
 
   std::string manifest_str;
   ASSERT_TRUE(file_util::ReadFileToString(manifest_path, &manifest_str))
       << "Failed to load: " << manifest_path.value();
 
   ExtensionAPI api;
-  api.RegisterSchema("test.foo", manifest_str);
+  // TODO(cduvall): MAKE THIS WORK

[cduvall, 2013/05/17 03:09:30]

Still fixing the unit tests.

+  api.RegisterSchemaResource("test.foo", 0);
 
   const base::DictionaryValue* schema = api.GetSchema("test.foo");
 
   const base::DictionaryValue* dict;
   const base::DictionaryValue* sub_dict;
   std::string type;
 
   GetDictionaryFromList(schema, "types", 0, &dict);
   EXPECT_TRUE(dict->GetString("id", &type));
   EXPECT_EQ("test.foo.TestType", type);
@@ skipping 28 matching lines @@
   GetDictionaryFromList(dict, "parameters", 0, &sub_dict);
   EXPECT_TRUE(sub_dict->GetString("$ref", &type));
   EXPECT_EQ("test.foo.TestType", type);
   GetDictionaryFromList(dict, "parameters", 1, &sub_dict);
   EXPECT_TRUE(sub_dict->GetString("$ref", &type));
   EXPECT_EQ("fully.qualified.Type", type);
 }
 
 }  // namespace
 }  // namespace extensions