Replace more static casts in FWL (part 3)

Replace more static casts in FWL (part 3)

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/33c8c7602f8981c32d37a9b2e25496401e914391

[Tom Sepez, 2015-12-08 00:47:05]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-12-08 00:47:06]

Lei, for review.

https://codereview.chromium.org/1508883003/diff/1/xfa/include/fwl/core/fwl_no...
File xfa/include/fwl/core/fwl_note.h (right):

https://codereview.chromium.org/1508883003/diff/1/xfa/include/fwl/core/fwl_no...
xfa/include/fwl/core/fwl_note.h:181: wsClass = L" ## classname ## ";            
                \
Note: This probably doesn't do what they think it does.

https://codereview.chromium.org/1508883003/diff/1/xfa/src/fwl/src/core/fwl_gr...
File xfa/src/fwl/src/core/fwl_gridimp.cpp (right):

https://codereview.chromium.org/1508883003/diff/1/xfa/src/fwl/src/core/fwl_gr...
xfa/src/fwl/src/core/fwl_gridimp.cpp:331: CFWL_GridColRow* pColRow =
reinterpret_cast<CFWL_GridColRow*>(hColRow);
Note: FWL_Hxxxxxx types are an unrelated struct that hides details.  We'll
remove them later.

https://codereview.chromium.org/1508883003/diff/1/xfa/src/fwl/src/core/fwl_pa...
File xfa/src/fwl/src/core/fwl_panelimp.cpp (right):

https://codereview.chromium.org/1508883003/diff/1/xfa/src/fwl/src/core/fwl_pa...
xfa/src/fwl/src/core/fwl_panelimp.cpp:65: pGrid->GetWidgetSize(GetInterface(),
FWL_GRIDSIZE_Width, eWidth);
yow.

https://codereview.chromium.org/1508883003/diff/1/xfa/src/fwl/src/core/includ...
File xfa/src/fwl/src/core/include/fwl_noteimp.h (right):

https://codereview.chromium.org/1508883003/diff/1/xfa/src/fwl/src/core/includ...
xfa/src/fwl/src/core/include/fwl_noteimp.h:21: class CFWL_NoteLoop : public
IFWL_NoteLoop {
yow.

https://codereview.chromium.org/1508883003/diff/1/xfa/src/fwl/src/lightwidget...
File xfa/src/fwl/src/lightwidget/listbox.cpp (right):

https://codereview.chromium.org/1508883003/diff/1/xfa/src/fwl/src/lightwidget...
xfa/src/fwl/src/lightwidget/listbox.cpp:45:
reinterpret_cast<CFWL_ListItem*>(m_ListBoxDP.GetItem(m_pIface, nIndex));
yow.

[Lei Zhang, 2015-12-09 04:22:12]

Isn't this going to conflict with 2 of your other CLs?

https://codereview.chromium.org/1508883003/diff/1/xfa/include/fwl/core/fwl_no...
File xfa/include/fwl/core/fwl_note.h (right):

https://codereview.chromium.org/1508883003/diff/1/xfa/include/fwl/core/fwl_no...
xfa/include/fwl/core/fwl_note.h:181: wsClass = L" ## classname ## ";            
                \
On 2015/12/08 00:47:06, Tom Sepez wrote:
> Note: This probably doesn't do what they think it does.

Don't you have another CL to fix this? Or is that for another instance?

https://codereview.chromium.org/1508883003/diff/1/xfa/src/fwl/src/core/fwl_gr...
File xfa/src/fwl/src/core/fwl_gridimp.cpp (right):

https://codereview.chromium.org/1508883003/diff/1/xfa/src/fwl/src/core/fwl_gr...
xfa/src/fwl/src/core/fwl_gridimp.cpp:229:
pGraphics->ConcatMatrix(const_cast<CFX_Matrix*>(pMatrix));
Can ConcatMatrix() just take a const pointer instead? Works for me locally.

https://codereview.chromium.org/1508883003/diff/1/xfa/src/fwl/src/core/fwl_no...
File xfa/src/fwl/src/core/fwl_noteimp.cpp (right):

https://codereview.chromium.org/1508883003/diff/1/xfa/src/fwl/src/core/fwl_no...
xfa/src/fwl/src/core/fwl_noteimp.cpp:500: case FWL_MSGHASH_TaskClicked:
Why bother writing out these cases?

https://codereview.chromium.org/1508883003/diff/1/xfa/src/fwl/src/core/fwl_no...
xfa/src/fwl/src/core/fwl_noteimp.cpp:670: if (pDst)
You are missing the '!' ??

https://codereview.chromium.org/1508883003/diff/1/xfa/src/fwl/src/core/fwl_wi...
File xfa/src/fwl/src/core/fwl_widgetmgrimp.cpp (right):

https://codereview.chromium.org/1508883003/diff/1/xfa/src/fwl/src/core/fwl_wi...
xfa/src/fwl/src/core/fwl_widgetmgrimp.cpp:858:
const_cast<CFX_Matrix*>(pMatrix));
Boo to const casts.

[Tom Sepez, 2015-12-09 20:41:19]

Yeah, this is going to have get rebased.

[Tom Sepez, 2015-12-10 01:06:32]

Lei, let's try again.  Thanks.

https://codereview.chromium.org/1508883003/diff/20001/xfa/src/fwl/src/core/fw...
File xfa/src/fwl/src/core/fwl_gridimp.cpp (right):

https://codereview.chromium.org/1508883003/diff/20001/xfa/src/fwl/src/core/fw...
xfa/src/fwl/src/core/fwl_gridimp.cpp:318: CFWL_GridColRow* pColRow =
reinterpret_cast<CFWL_GridColRow*>(hColRow);
Note: Opaque handles again.

[Lei Zhang, 2015-12-10 01:14:44]

https://codereview.chromium.org/1508883003/diff/60001/xfa/src/fwl/src/core/fw...
File xfa/src/fwl/src/core/fwl_gridimp.cpp (right):

https://codereview.chromium.org/1508883003/diff/60001/xfa/src/fwl/src/core/fw...
xfa/src/fwl/src/core/fwl_gridimp.cpp:216:
pGraphics->ConcatMatrix(const_cast<CFX_Matrix*>(pMatrix));
Just change ConcatMatrix() to take a const pointer instead.

https://codereview.chromium.org/1508883003/diff/60001/xfa/src/fwl/src/core/fw...
File xfa/src/fwl/src/core/fwl_noteimp.cpp (right):

https://codereview.chromium.org/1508883003/diff/60001/xfa/src/fwl/src/core/fw...
xfa/src/fwl/src/core/fwl_noteimp.cpp:500: case FWL_MSGHASH_TaskClicked:
Still wondering why we bother with these.

https://codereview.chromium.org/1508883003/diff/60001/xfa/src/fwl/src/core/fw...
xfa/src/fwl/src/core/fwl_noteimp.cpp:670: if (pDst)
Still missing the "!" !

https://codereview.chromium.org/1508883003/diff/60001/xfa/src/fwl/src/core/fw...
File xfa/src/fwl/src/core/fwl_widgetmgrimp.cpp (right):

https://codereview.chromium.org/1508883003/diff/60001/xfa/src/fwl/src/core/fw...
xfa/src/fwl/src/core/fwl_widgetmgrimp.cpp:858:
const_cast<CFX_Matrix*>(pMatrix));
Add a FIXME?

https://codereview.chromium.org/1508883003/diff/60001/xfa/src/fwl/src/lightwi...
File xfa/src/fwl/src/lightwidget/listbox.cpp (right):

https://codereview.chromium.org/1508883003/diff/60001/xfa/src/fwl/src/lightwi...
xfa/src/fwl/src/lightwidget/listbox.cpp:56: CFWL_ListItem* pSel =
(CFWL_ListItem*)m_ListBoxDP.GetItem(m_pIface, iSel);
C-style cast

https://codereview.chromium.org/1508883003/diff/60001/xfa/src/fwl/src/lightwi...
xfa/src/fwl/src/lightwidget/listbox.cpp:66: CFWL_ListItem* pItem =
(CFWL_ListItem*)m_ListBoxDP.GetItem(m_pIface, i);
C-style cast, they are everywhere!

[Tom Sepez, 2015-12-10 18:08:03]

Ah, many of these still remained. sorry. PTAL.

https://codereview.chromium.org/1508883003/diff/60001/xfa/src/fwl/src/core/fw...
File xfa/src/fwl/src/core/fwl_gridimp.cpp (right):

https://codereview.chromium.org/1508883003/diff/60001/xfa/src/fwl/src/core/fw...
xfa/src/fwl/src/core/fwl_gridimp.cpp:216:
pGraphics->ConcatMatrix(const_cast<CFX_Matrix*>(pMatrix));
On 2015/12/10 01:14:43, Lei Zhang wrote:
> Just change ConcatMatrix() to take a const pointer instead.

Done.

https://codereview.chromium.org/1508883003/diff/60001/xfa/src/fwl/src/core/fw...
File xfa/src/fwl/src/core/fwl_noteimp.cpp (right):

https://codereview.chromium.org/1508883003/diff/60001/xfa/src/fwl/src/core/fw...
xfa/src/fwl/src/core/fwl_noteimp.cpp:500: case FWL_MSGHASH_TaskClicked:
On 2015/12/10 01:14:43, Lei Zhang wrote:
> Still wondering why we bother with these.

removed.

https://codereview.chromium.org/1508883003/diff/60001/xfa/src/fwl/src/core/fw...
xfa/src/fwl/src/core/fwl_noteimp.cpp:670: if (pDst)
On 2015/12/10 01:14:43, Lei Zhang wrote:
> Still missing the "!" !
I am stupid.

https://codereview.chromium.org/1508883003/diff/60001/xfa/src/fwl/src/core/fw...
File xfa/src/fwl/src/core/fwl_widgetmgrimp.cpp (right):

https://codereview.chromium.org/1508883003/diff/60001/xfa/src/fwl/src/core/fw...
xfa/src/fwl/src/core/fwl_widgetmgrimp.cpp:858:
const_cast<CFX_Matrix*>(pMatrix));
On 2015/12/10 01:14:44, Lei Zhang wrote:
> Add a FIXME?

Added consts to Transfer() instead.

https://codereview.chromium.org/1508883003/diff/60001/xfa/src/fwl/src/lightwi...
File xfa/src/fwl/src/lightwidget/listbox.cpp (right):

https://codereview.chromium.org/1508883003/diff/60001/xfa/src/fwl/src/lightwi...
xfa/src/fwl/src/lightwidget/listbox.cpp:56: CFWL_ListItem* pSel =
(CFWL_ListItem*)m_ListBoxDP.GetItem(m_pIface, iSel);
On 2015/12/10 01:14:44, Lei Zhang wrote:
> C-style cast

Ok, I'lll fix these.  I was ignoring these in hopes that a future CL would get
rid of all this "FWL_Hxxxxxxx" nonsense ...

https://codereview.chromium.org/1508883003/diff/60001/xfa/src/fwl/src/lightwi...
xfa/src/fwl/src/lightwidget/listbox.cpp:66: CFWL_ListItem* pItem =
(CFWL_ListItem*)m_ListBoxDP.GetItem(m_pIface, i);
On 2015/12/10 01:14:44, Lei Zhang wrote:
> C-style cast, they are everywhere!

Done.

[Lei Zhang, 2015-12-10 18:51:44]

lgtm

[Tom Sepez, 2015-12-10 20:30:06]

Description was changed from

==========
Replace more static casts in FWL (part 3)
==========

to

==========
Replace more static casts in FWL (part 3)

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/33c8c7602f8981c32d37a9b2e25496401e91...
==========

[Tom Sepez, 2015-12-10 20:30:07]

Committed patchset #6 (id:100001) manually as
33c8c7602f8981c32d37a9b2e25496401e914391 (presubmit successful).