Replace more static casts in FWL (part 3)

xfa/include/fwl/core/fwl_note.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef _FWL_NOTE_H
 #define _FWL_NOTE_H
 class IFWL_Target;
 class IFWL_Widget;
@@ skipping 151 matching lines @@
 
  public:
   FX_DWORD m_dwExtend;
 };
 class CFWL_Message : public CFWL_Note {
  public:
   CFWL_Message() : CFWL_Note(FALSE) {}
   virtual ~CFWL_Message() {}
   virtual CFWL_Event* CloneToEvent() { return NULL; }
 };
+
+// FIXME: CloneToEvent() relies on events having the same layout as
+// messages, and the hash in the "event" will be wrong, too.
 #define BEGIN_FWL_MESSAGE_DEF(classname, msghashcode)             \
   class classname : public CFWL_Message {                         \
    public:                                                        \
     classname() : CFWL_Message() {}                               \
     virtual CFWL_Note* Clone() { return new classname(*this); }   \
     virtual FWL_ERR GetClassName(CFX_WideString& wsClass) const { \
       wsClass = L" ## classname ## ";                             \

[Tom Sepez, 2015/12/08 00:47:06]

Note: This probably doesn't do what they think it does.

[Lei Zhang, 2015/12/09 04:22:11]

Don't you have another CL to fix this? Or is that for another instance?

       return FWL_ERR_Succeeded;                                   \
     }                                                             \
     virtual FX_DWORD GetClassID() const { return msghashcode; }   \
     virtual CFWL_Event* CloneToEvent() {                          \
       classname* pEvent = new classname;                          \
       pEvent->m_bIsEvent = TRUE;                                  \
-      return (CFWL_Event*)pEvent;                                 \
+      return reinterpret_cast<CFWL_Event*>(pEvent);               \
     }
 #define END_FWL_MESSAGE_DEF \
   }                         \
   ;
 BEGIN_FWL_MESSAGE_DEF(CFWL_MsgActivate, FWL_MSGHASH_Activate)
 END_FWL_MESSAGE_DEF
 BEGIN_FWL_MESSAGE_DEF(CFWL_MsgDeactivate, FWL_MSGHASH_Deactivate)
 END_FWL_MESSAGE_DEF
 BEGIN_FWL_MESSAGE_DEF(CFWL_MsgMouse, FWL_MSGHASH_Mouse)
 FX_FLOAT m_fx;
@@ skipping 172 matching lines @@
 };
 FWL_ERR FWL_AddToolTipTarget(IFWL_ToolTipTarget* pTarget);
 FWL_ERR FWL_RemoveToolTipTarget(IFWL_ToolTipTarget* pTarget);
 FWL_ERR FWL_SetToolTipInitialDelay(int32_t iDelayTime);
 FWL_ERR FWL_SetToolTipAutoPopDelay(int32_t iDelayTime);
 typedef FX_BOOL (*FWLMessageHookCallback)(CFWL_Message* msg, void* info);
 FWL_ERR FWL_SetHook(IFWL_NoteDriver* driver,
                     FWLMessageHookCallback callback,
                     void* info);
 #endif