Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 150883005: IDL compiler: sync Python to r166989 (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: sync Python to r166989 Python side to: Oilpan: Remove GarbageCollected::ref/deref https://codereview.chromium.org/156033003 Also fixes formatting in Perl. BUG=239771 TBR=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167005

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -3 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestException.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor3.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDoNotCheckConstants.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDocument.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEmpty.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventTarget.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython2.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython3.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestNode.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestSVG.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsCustom.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsInt.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsNotEnumerable.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
6 years, 10 months ago (2014-02-12 11:33:22 UTC) #1
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-12 11:33:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/150883005/1
6 years, 10 months ago (2014-02-12 11:33:40 UTC) #3
haraken
LGTM
6 years, 10 months ago (2014-02-12 12:02:59 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 13:09:43 UTC) #5
Message was sent while issue was closed. 
Change committed as 167005

Powered by Google App Engine
This is Rietveld 408576698