Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1508743002: Delete "Delete" JS builtin (Closed)

Created:
5 years ago by Jakob Kummerow
Modified:
5 years ago
Reviewers:
Camillo Bruni, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Delete "Delete" JS builtin Use %DeleteProperty_Strict instead. Committed: https://crrev.com/afcfee836d0f741ad848c0e58d208ae7247cd2e2 Cr-Commit-Position: refs/heads/master@{#32673}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -20 lines) Patch
M src/js/array.js View 3 chunks +1 line, -4 lines 0 comments Download
M src/js/v8natives.js View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Jakob Kummerow
One step closer to getting rid of GetOwnPropertyJS(). Tests are passing so it must be ...
5 years ago (2015-12-07 16:38:22 UTC) #2
Camillo Bruni
lgtm
5 years ago (2015-12-07 16:58:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508743002/1
5 years ago (2015-12-07 17:07:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8618)
5 years ago (2015-12-07 17:22:23 UTC) #7
Jakob Kummerow
Yang, please do an OWNERS' review.
5 years ago (2015-12-07 21:14:51 UTC) #9
Yang
On 2015/12/07 21:14:51, Jakob wrote: > Yang, please do an OWNERS' review. lgtm
5 years ago (2015-12-08 00:44:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508743002/1
5 years ago (2015-12-08 08:50:32 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 08:51:42 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-08 08:52:24 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afcfee836d0f741ad848c0e58d208ae7247cd2e2
Cr-Commit-Position: refs/heads/master@{#32673}

Powered by Google App Engine
This is Rietveld 408576698