Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1604)

Unified Diff: src/js/array.js

Issue 1508743002: Delete "Delete" JS builtin (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/js/v8natives.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/array.js
diff --git a/src/js/array.js b/src/js/array.js
index e36dcb66ccfc3e7f15781b553284a78906cd9607..65ada1e39035ace64d48da44d88ba98623425533 100644
--- a/src/js/array.js
+++ b/src/js/array.js
@@ -12,7 +12,6 @@
// Imports
var AddIndexedProperty;
-var Delete;
var FLAG_harmony_tolength;
var GetIterator;
var GetMethod;
@@ -35,7 +34,6 @@ var unscopablesSymbol = utils.ImportNow("unscopables_symbol");
utils.Import(function(from) {
AddIndexedProperty = from.AddIndexedProperty;
- Delete = from.Delete;
GetIterator = from.GetIterator;
GetMethod = from.GetMethod;
MakeTypeError = from.MakeTypeError;
@@ -490,8 +488,7 @@ function ArrayPop() {
n--;
var value = array[n];
- // TODO(jkummerow): Use %DeleteProperty_Strict instead, delete "Delete".
- Delete(array, n, true);
+ %DeleteProperty_Strict(array, n);
array.length = n;
return value;
}
« no previous file with comments | « no previous file | src/js/v8natives.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698