Use WeakCells in the optimized code map rather than traversing in pause.

Use WeakCells in the optimized code map rather than traversing in pause.

It's expensive to walk all shared function infos during the gc atomic
pause. Instead, use WeakCells to implement this structure without
manual clearing.

Reland due to a bug when reusing entries in the optimized code map.

BUG=

Committed: https://crrev.com/e56fe8460ade6208b878bf95b3a5a1298cf4ccea
Cr-Commit-Position: refs/heads/master@{#32696}

[mvstanton, 2015-12-07 15:18:14]

Description was changed from

==========
Use WeakCells in the optimized code map rather than traversing in pause.

It's expensive to walk all shared function infos during the gc atomic
pause. Instead, use WeakCells to implement this structure without
manual clearing.

Reland due to a bug when reusing entries in the optimized code map.

BUG=
==========

to

==========
Use WeakCells in the optimized code map rather than traversing in pause.

It's expensive to walk all shared function infos during the gc atomic
pause. Instead, use WeakCells to implement this structure without
manual clearing.

Reland due to a bug when reusing entries in the optimized code map.

BUG=
==========

[mvstanton, 2015-12-07 15:18:14]

mvstanton@chromium.org changed reviewers:
+ mstarzinger@chromium.org, ulan@chromium.org

[mvstanton, 2015-12-07 15:19:20]

Hi Michi, hi Ulan,
Here is the reland of WeakCells in the optimized code map with the bug
addressed, and a (rather long) test which verifies cleared entries in the
optimized code map are reused.

The delta between patch 1 and 2 is the new stuff. Thanks!
--Mike

[Michael Starzinger, 2015-12-07 17:29:09]

LGTM (rubber-stamped).

[ulan, 2015-12-08 08:47:06]

lgtm

https://codereview.chromium.org/1508703002/diff/40001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1508703002/diff/40001/src/objects.cc#newcode1...
src/objects.cc:12006: if (old_code_map != *new_code_map) {
Since we are using weak cells now, there is no need to zap the old array.

[mvstanton, 2015-12-08 10:27:26]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2015-12-08 10:27:26]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1508703002/#ps60001
(title: "REBASE plus comment response.")

[commit-bot: I haz the power, 2015-12-08 10:27:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1508703002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1508703002/60001

[commit-bot: I haz the power, 2015-12-08 11:49:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 11:49:50]

Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)

[mvstanton, 2015-12-08 16:40:12]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2015-12-08 16:40:29]

Thanks guys!

https://codereview.chromium.org/1508703002/diff/40001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1508703002/diff/40001/src/objects.cc#newcode1...
src/objects.cc:12006: if (old_code_map != *new_code_map) {
On 2015/12/08 08:47:06, ulan wrote:
> Since we are using weak cells now, there is no need to zap the old array.

Good point! Removed that here and in the function below,
ClearOptimizedCodeMap().

[commit-bot: I haz the power, 2015-12-08 16:40:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1508703002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1508703002/60001

[commit-bot: I haz the power, 2015-12-08 20:30:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 20:30:10]

Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/11175)

[mvstanton, 2015-12-09 07:28:39]

The CQ bit was checked by mvstanton@chromium.org

[commit-bot: I haz the power, 2015-12-09 07:28:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1508703002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1508703002/60001

[commit-bot: I haz the power, 2015-12-09 07:30:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 07:30:22]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8694)

[mvstanton, 2015-12-09 08:19:17]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2015-12-09 08:19:17]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1508703002/#ps100001
(title: "Fixed nit.")

[commit-bot: I haz the power, 2015-12-09 08:19:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1508703002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1508703002/100001

[commit-bot: I haz the power, 2015-12-09 08:54:52]

Description was changed from

==========
Use WeakCells in the optimized code map rather than traversing in pause.

It's expensive to walk all shared function infos during the gc atomic
pause. Instead, use WeakCells to implement this structure without
manual clearing.

Reland due to a bug when reusing entries in the optimized code map.

BUG=
==========

to

==========
Use WeakCells in the optimized code map rather than traversing in pause.

It's expensive to walk all shared function infos during the gc atomic
pause. Instead, use WeakCells to implement this structure without
manual clearing.

Reland due to a bug when reusing entries in the optimized code map.

BUG=
==========

[commit-bot: I haz the power, 2015-12-09 08:54:57]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-12-09 08:55:42]

Description was changed from

==========
Use WeakCells in the optimized code map rather than traversing in pause.

It's expensive to walk all shared function infos during the gc atomic
pause. Instead, use WeakCells to implement this structure without
manual clearing.

Reland due to a bug when reusing entries in the optimized code map.

BUG=
==========

to

==========
Use WeakCells in the optimized code map rather than traversing in pause.

It's expensive to walk all shared function infos during the gc atomic
pause. Instead, use WeakCells to implement this structure without
manual clearing.

Reland due to a bug when reusing entries in the optimized code map.

BUG=

Committed: https://crrev.com/e56fe8460ade6208b878bf95b3a5a1298cf4ccea
Cr-Commit-Position: refs/heads/master@{#32696}
==========

[commit-bot: I haz the power, 2015-12-09 08:55:43]

Patchset 6 (id:??) landed as
https://crrev.com/e56fe8460ade6208b878bf95b3a5a1298cf4ccea
Cr-Commit-Position: refs/heads/master@{#32696}