src/objects-inl.h - Issue 1508703002: Use WeakCells in the optimized code map rather than traversing in pause.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 1508703002: Use WeakCells in the optimized code map rather than traversing in pause. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fixed nit. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index 13fb9e2dfd44ec7b1121ac11d28fe9effee93c06..cbb19531b5bb1127f9e742ace0c4b8ed07422e56 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -2029,7 +2029,10 @@ Object* WeakCell::value() const { return READ_FIELD(this, kValueOffset); }

void WeakCell::clear() {

- DCHECK(GetHeap()->gc_state() == Heap::MARK_COMPACT);

+ // Either the garbage collector is clearing the cell or we are simply

+ // initializing the root empty weak cell.

+ DCHECK(GetHeap()->gc_state() == Heap::MARK_COMPACT ||

+ this == GetHeap()->empty_weak_cell());

WRITE_FIELD(this, kValueOffset, Smi::FromInt(0));

}

« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »