Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 1508423004: Remove String::reverseFindIgnoringCase (Closed)

Created:
5 years ago by fs
Modified:
5 years ago
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove String::reverseFindIgnoringCase No longer used. Also remove the "dynamic" TextCaseSensitivity version of String::reverseFind. BUG=565878 Committed: https://crrev.com/2c9349d307253cf313ee2c7003082504eec38de9 Cr-Commit-Position: refs/heads/master@{#364375}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -47 lines) Patch
M third_party/WebKit/Source/wtf/text/StringImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.h View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
(Part 3 of https://codereview.chromium.org/1499933003) PTAL
5 years ago (2015-12-10 12:50:30 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-12-10 15:34:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508423004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508423004/1
5 years ago (2015-12-10 15:49:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 16:15:44 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-10 16:17:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c9349d307253cf313ee2c7003082504eec38de9
Cr-Commit-Position: refs/heads/master@{#364375}

Powered by Google App Engine
This is Rietveld 408576698