Subzero. ARM32. Introduces explicit register parameter attribute.

Makefile.standalone

Index: Makefile.standalone
diff --git a/Makefile.standalone b/Makefile.standalone
index 940817c91d8992c227ae8360123de979c1815d8c..3da5de23fb8a63cfc887927200a2e7dcad2be164 100644
--- a/Makefile.standalone
+++ b/Makefile.standalone
@@ -325,6 +325,11 @@ $(SB_OBJDIR)/pnacl-sz.x86-32.nexe: $(SB_OBJS)
 	$(SB_TRANSLATE) -arch x86-32 $(PNACL_SZ_BASE).nonfinal.pexe -o $@ \
           --allow-llvm-bitcode-input
 
+src/IceRegistersARM32.def: pydir/gen_arm32_reg_tables.py
+	echo "IceRegistersARM32.def is out-of-date. Please regenerate it with " \

[Jim Stichnoth, 2015/12/11 18:47:41]

80-col, thanks tab characters!

Could this makefile just regenerate the .def file if it's out of date?

[Jim Stichnoth, 2015/12/11 20:15:24]

Answering a question posed offline...

We can assume that Makefile.standalone is run in an environment that has python
available.  After all, "check-lit" uses lit which uses python; "check-xtest"
uses crosstest python scripts; "check-spec" uses the szbuild scripts.

The "official" builder builds Subzero as part of the greater LLVM build, and
uses Makefile rather than Makefile.standalone.  Under this development model,
any changes to the .py file might result in changes to the .def file after the
Makefile.standalone reruns the .py script, and those changes would become part
of the CL.  The script might spuriously fire due to timestamp issues, but as
long as it produces the same output, all should be fine.

[John, 2015/12/11 20:23:32]

Done.

+             "pydir/gen_arm32_reg_tables.py"
+	exit 1
+
 # TODO(stichnot): Be more precise than "*.h" here and elsewhere.
 $(OBJS): $(OBJDIR)/%.o: src/%.cpp src/*.h src/*.def
 	$(CXX) -c $(CXXFLAGS) $< -o $@