Subzero. ARM32. Introduces explicit register parameter attribute.

Makefile.standalone

 # The following variables will likely need to be modified, depending on where
 # and how you built LLVM & Clang. They can be overridden in a command-line
 # invocation of make, like:
 #
 #   make LLVM_SRC_PATH=<path> LIBCXX_INSTALL_PATH=<path> CLANG_PATH=<path> \
 #        PNACL_BIN_PATH=<path> ...
 #
 
 # LLVM_SRC_PATH is the path to the root of the checked out source code. This
 # directory should contain the configure script, the include/ and lib/
@@ skipping 307 matching lines @@
         $(CXX) $(LDFLAGS) -o $@ $^ $(LLVM_LDFLAGS) \
           -Wl,-rpath=$(abspath $(LIBCXX_INSTALL_PATH)/lib)
 
 $(SB_OBJDIR)/pnacl-sz.x86-32.nexe: $(SB_OBJS)
         $(eval PNACL_SZ_BASE := $(patsubst %.nexe, %, $@))
         $(SB_CXX) $(SB_LDFLAGS) -o $(PNACL_SZ_BASE).nonfinal.pexe $^ \
           $(SB_LLVM_LDFLAGS)
         $(SB_TRANSLATE) -arch x86-32 $(PNACL_SZ_BASE).nonfinal.pexe -o $@ \
           --allow-llvm-bitcode-input
 
+src/IceRegistersARM32.def: pydir/gen_arm32_reg_tables.py
+        echo "IceRegistersARM32.def is out-of-date. Please regenerate it with " \

[Jim Stichnoth, 2015/12/11 18:47:41]

80-col, thanks tab characters!

Could this makefile just regenerate the .def file if it's out of date?

[Jim Stichnoth, 2015/12/11 20:15:24]

Answering a question posed offline...

We can assume that Makefile.standalone is run in an environment that has python
available.  After all, "check-lit" uses lit which uses python; "check-xtest"
uses crosstest python scripts; "check-spec" uses the szbuild scripts.

The "official" builder builds Subzero as part of the greater LLVM build, and
uses Makefile rather than Makefile.standalone.  Under this development model,
any changes to the .py file might result in changes to the .def file after the
Makefile.standalone reruns the .py script, and those changes would become part
of the CL.  The script might spuriously fire due to timestamp issues, but as
long as it produces the same output, all should be fine.

[John, 2015/12/11 20:23:32]

Done.

+             "pydir/gen_arm32_reg_tables.py"
+        exit 1
+
 # TODO(stichnot): Be more precise than "*.h" here and elsewhere.
 $(OBJS): $(OBJDIR)/%.o: src/%.cpp src/*.h src/*.def
         $(CXX) -c $(CXXFLAGS) $< -o $@
 
 $(SB_OBJS): $(SB_OBJDIR)/%.o: src/%.cpp src/*.h src/*.def
         $(SB_CXX) -c $(SB_CXXFLAGS) $< -o $@
 
 $(OBJDIR)/run_unittests: $(UNITTEST_OBJS) $(UNITTEST_LIB_OBJS)
         $(CXX) $(GTEST_LIB_PATH) $(LDFLAGS) -o $@ $^ $(LLVM_LDFLAGS) \
           -lgtest -lgtest_main -ldl \
@@ skipping 160 matching lines @@
 
 docs:
         doxygen Doxyfile
         @echo See file://`pwd`/docs/html/index.html
 
 clean:
         rm -rf pnacl-sz *.o $(OBJDIR) $(SB_OBJDIR) build/pnacl-sz.bloat.json
 
 clean-all: clean
         rm -rf build/ docs/