Subzero. ARM32. Introduces explicit register parameter attribute.

src/IceTargetLoweringARM32.h

Index: src/IceTargetLoweringARM32.h
diff --git a/src/IceTargetLoweringARM32.h b/src/IceTargetLoweringARM32.h
index 12de2fb77b95485beead07f07af9527cc1dae849..ccb4f025113f145875e8e99cfe27207b9f4b3950 100644
--- a/src/IceTargetLoweringARM32.h
+++ b/src/IceTargetLoweringARM32.h
@@ -1046,34 +1046,30 @@ protected:
     CallingConv &operator=(const CallingConv &) = delete;
 
   public:
-    CallingConv()
-        : VFPRegsFree(ARM32_MAX_FP_REG_UNITS, true),
-          ValidF64Regs(ARM32_MAX_FP_REG_UNITS),
-          ValidV128Regs(ARM32_MAX_FP_REG_UNITS) {
-      for (uint32_t i = 0; i < ARM32_MAX_FP_REG_UNITS; ++i) {
-        if ((i % 2) == 0) {
-          ValidF64Regs[i] = true;
-        }
-        if ((i % 4) == 0) {
-          ValidV128Regs[i] = true;
-        }
-      }
-    }
+    CallingConv();
     ~CallingConv() = default;
 
-    bool I64InRegs(std::pair<int32_t, int32_t> *Regs);
-    bool I32InReg(int32_t *Reg);
-    bool FPInReg(Type Ty, int32_t *Reg);
+    /// argInGPR returns true if there is a GPR available for the requested
+    /// type, and false otherwise. If if returns true, Reg is set to the

[Jim Stichnoth, 2015/12/10 19:04:06]

If it

[John, 2015/12/11 15:43:30]

Done.

+    /// appropriate register number. Note that, when Ty == IceType_i64, Reg will
+    /// be an I64 register pair.
+    bool argInGPR(Type Ty, int32_t *Reg);
 
-    static constexpr uint32_t ARM32_MAX_GPR_ARG = 4;
-    // TODO(jpp): comment.
-    static constexpr uint32_t ARM32_MAX_FP_REG_UNITS = 16;
+    /// argInVFP is to floating-point/vector types what argInGPR is for integer
+    /// types.
+    bool argInVFP(Type Ty, int32_t *Reg);
 
   private:
-    uint32_t NumGPRRegsUsed = 0;
-    llvm::SmallBitVector VFPRegsFree;
-    llvm::SmallBitVector ValidF64Regs;
-    llvm::SmallBitVector ValidV128Regs;
+    void discardUnavailableGPRsAndTheirAliases(std::vector<SizeT> *Regs);

[Jim Stichnoth, 2015/12/10 19:04:06]

Can you use CfgVector instead of std::vector?

[John, 2015/12/11 15:43:29]

Done.

+    llvm::SmallBitVector GPRegsUsed;
+    std::vector<SizeT> GPRArgs;
+    std::vector<SizeT> I64Args;
+
+    void discardUnavailableVFPRegs(std::vector<SizeT> *Regs);
+    llvm::SmallBitVector VFPRegsUsed;
+    std::vector<SizeT> FP32Args;
+    std::vector<SizeT> FP64Args;
+    std::vector<SizeT> Vec128Args;
   };
 
 private: