Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 1508303003: Show floating VK on first tap (Closed)

Created:
5 years ago by bshe
Modified:
4 years, 11 months ago
Reviewers:
Shu Chen, sadrul
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show floating VK on first tap BUG=568274 Committed: https://crrev.com/af9593f9c4960f5397082f8b8cb0dfd8c2208c17 Cr-Commit-Position: refs/heads/master@{#367311}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -10 lines) Patch
M ui/keyboard/keyboard_controller_unittest.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
M ui/keyboard/keyboard_layout_manager.cc View 1 chunk +10 lines, -10 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (3 generated)
bshe
Hi Shu and Sadrul. Do you mind to take a look at this CL? We ...
5 years ago (2015-12-09 22:49:43 UTC) #2
bshe
On 2015/12/09 22:49:43, bshe wrote: > Hi Shu and Sadrul. > > Do you mind ...
5 years ago (2015-12-14 14:16:32 UTC) #3
Shu Chen
lgtm
5 years ago (2015-12-20 15:00:28 UTC) #4
sadrul
stamp lgtm
5 years ago (2015-12-21 19:03:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508303003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508303003/20001
4 years, 11 months ago (2016-01-04 15:04:32 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-04 16:12:34 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 16:13:23 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/af9593f9c4960f5397082f8b8cb0dfd8c2208c17
Cr-Commit-Position: refs/heads/master@{#367311}

Powered by Google App Engine
This is Rietveld 408576698