Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Unified Diff: mojo/public/tools/bindings/generators/mojom_java_generator.py

Issue 1508293004: Simplify Go's Mojom Type Generator (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Add generate_type_info flag to mojom generators Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/tools/bindings/generators/mojom_java_generator.py
diff --git a/mojo/public/tools/bindings/generators/mojom_java_generator.py b/mojo/public/tools/bindings/generators/mojom_java_generator.py
index 554db742aa085fca26985b6b01b841c7a5bb76c2..0019e26c30218978fb64cb0e58223dd84be173aa 100644
--- a/mojo/public/tools/bindings/generators/mojom_java_generator.py
+++ b/mojo/public/tools/bindings/generators/mojom_java_generator.py
@@ -497,7 +497,7 @@ class Generator(generator.Generator):
def GenerateFiles(self, unparsed_args):
parser = argparse.ArgumentParser()
parser.add_argument('--java_output_directory', dest='java_output_directory')
- args = parser.parse_args(unparsed_args)
+ (args, _) = parser.parse_known_args(unparsed_args)
azani 2015/12/18 18:12:58 Why is this change here?
alexfandrianto 2015/12/18 19:08:31 This change is here because the new argument will
azani 2015/12/18 23:19:11 Can you add an argument to parser instead?
alexfandrianto 2015/12/18 23:24:10 Done.
package_path = GetPackage(self.module).replace('.', '/')
# Generate the java files in a temporary directory and place a single

Powered by Google App Engine
This is Rietveld 408576698