Simplify Go's Mojom Type Generator

mojo/public/tools/bindings/generators/mojom_java_generator.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generates java source files from a mojom.Module."""
 
 import argparse
 import ast
 import contextlib
 import os
@@ skipping 479 matching lines @@
       self.Write(self.GenerateInterfaceInternalSource(interface),
                  '%s_Internal.java' % GetNameForElement(interface))
 
     if self.module.constants:
       self.Write(self.GenerateConstantsSource(self.module),
                  '%s.java' % GetConstantsMainEntityName(self.module))
 
   def GenerateFiles(self, unparsed_args):
     parser = argparse.ArgumentParser()
     parser.add_argument('--java_output_directory', dest='java_output_directory')
-    args = parser.parse_args(unparsed_args)
+    (args, _) = parser.parse_known_args(unparsed_args)

[azani, 2015/12/18 18:12:58]

Why is this change here?

[alexfandrianto, 2015/12/18 19:08:31]

This change is here because the new argument will cause parse_args to throw
(since it is unrecognized).

[azani, 2015/12/18 23:19:11]

Can you add an argument to parser instead?

[alexfandrianto, 2015/12/18 23:24:10]

Done.

     package_path = GetPackage(self.module).replace('.', '/')
 
     # Generate the java files in a temporary directory and place a single
     # srcjar in the output directory.
     basename = self.MatchMojomFilePath("%s.srcjar" % self.module.name)
     zip_filename = os.path.join(self.output_dir, basename)
     with TempDir() as temp_java_root:
       self.output_dir = os.path.join(temp_java_root, package_path)
       self.DoGenerateFiles();
       ZipContentInto(temp_java_root, zip_filename)
 
     if args.java_output_directory:
       # If requested, generate the java files directly into indicated directory.
       self.output_dir = os.path.join(args.java_output_directory, package_path)
       self.DoGenerateFiles();
 
   def GetJinjaParameters(self):
     return {
       'lstrip_blocks': True,
       'trim_blocks': True,
     }
 
   def GetGlobals(self):
     return {
       'namespace': self.module.namespace,
       'module': self.module,
     }