chrome/browser/resources/settings/settings_page/settings_animated_pages.js - Issue 1508233002: Settings Rewrite: Update comments on related to routing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/settings_animated_pages.js

Issue 1508233002: Settings Rewrite: Update comments on related to routing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_page/settings_section.js » ('j') | chrome/browser/resources/settings/settings_page/settings_section.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/settings_animated_pages.js

diff --git a/chrome/browser/resources/settings/settings_page/settings_animated_pages.js b/chrome/browser/resources/settings/settings_page/settings_animated_pages.js

index c55f83584624394c9c672b1e1e1d9d9369f39972..8d9643635ee99b85556aea8c38b2b5fa843f364d 100644

--- a/chrome/browser/resources/settings/settings_page/settings_animated_pages.js

+++ b/chrome/browser/resources/settings/settings_page/settings_animated_pages.js

@@ -7,10 +7,13 @@

* 'settings-animated-pages' is a container for a page and animated subpages.

* It provides a set of common behaviors and animations.

+ * The section name must match the name specified in settings_router.js.

+ * Otherwise, settings-animated-pages will not transition between subpages.

+ *

* Example:

* <settings-animated-pages current-route="{{currentRoute}}"

- route-root="advanced/privacy" redirect-root-route-to="advanced">

+ * section="privacy">

*

* </settings-animated-pages>