chrome/browser/resources/settings/settings_page/settings_section.js - Issue 1508233002: Settings Rewrite: Update comments on related to routing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/settings_section.js

Issue 1508233002: Settings Rewrite: Update comments on related to routing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/settings_page/settings_animated_pages.js ('K') | « chrome/browser/resources/settings/settings_page/settings_animated_pages.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/settings_section.js

diff --git a/chrome/browser/resources/settings/settings_page/settings_section.js b/chrome/browser/resources/settings/settings_page/settings_section.js

index fd8da6df3bd5265ee85e28c25759d6dde9e770ac..67cb1d39a2471336db6236175d1c1e016d3e06d8 100644

--- a/chrome/browser/resources/settings/settings_page/settings_section.js

+++ b/chrome/browser/resources/settings/settings_page/settings_section.js

@@ -7,9 +7,12 @@

* 'settings-section' shows a paper material themed section with a header

* which shows its page title.

+ * The section name must match the name specified in settings_router.js.

+ * Otherwise, settings-section will not expand and contract correctly.

+ *

* Example:

- * <settings-section page-title="[[pageTitle]]">

+ * <settings-section page-title="[[pageTitle]]" section="privacy">

*

* </settings-section>