Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1508133003: Make app.cpp match XFA (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M fpdfsdk/src/javascript/app.cpp View 2 chunks +8 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Lei, these line up better against the ifdefs in xfa.
5 years ago (2015-12-08 19:14:27 UTC) #2
Lei Zhang
lgtm
5 years ago (2015-12-08 19:20:18 UTC) #3
Tom Sepez
5 years ago (2015-12-08 19:30:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b3ea5b41a3f472fe2b3ecf68129382b51ede6c3a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698