Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1504413002: Fix non-xfa build on xfa branch. (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Fix non-xfa build on xfa branch. Broken at 487d1a9/a0217b6. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/4d6fa834ccc7fb8a7ada0db2235c866e20cd4b40

Patch Set 1 #

Patch Set 2 : whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M fpdfsdk/src/javascript/app.cpp View 1 4 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, missing ifdef from one of Jun's recent changes.
5 years ago (2015-12-08 19:13:06 UTC) #1
Lei Zhang
lgtm
5 years ago (2015-12-08 19:19:18 UTC) #2
Tom Sepez
5 years ago (2015-12-08 19:32:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4d6fa834ccc7fb8a7ada0db2235c866e20cd4b40 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698