Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 15080010: Add special handling of rectori case for gpu (Closed)

Created:
7 years, 7 months ago by robertphillips
Modified:
7 years, 7 months ago
Reviewers:
bsalomon, caryclark, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

I'm a bit disappointed in the performance improvement but the blurs still appear to dominate (in both the rectori GM and theverge skp). GMs (old on left; new on right; everything <= .5ms || <= 3% || not appearing in two passes with repeat=100 removed): ----- ovals_3_stroke_4 GPU c 9.20 10.14 -0.94 -10.2% tablebench GPU c 23.24 24.02 -0.78 -3.4% rectori GPU c 81.59 70.36 +11.23 +13.8% ----- For bench_pictures (with same removals as with the GMs): ----- desk_yahoonews.skp tile_256x256_gpu c 69.26 66.14 +3.12 +4.5% tabl_mlb.skp tile_256x256_gpu c 49.30 46.64 +2.66 +5.4% tabl_nofolo.skp tile_256x256_gpu c 13.26 12.48 +0.78 +5.9% tabl_theverge.skp tile_256x256_gpu c 211.38 193.44 +17.94 +8.5% tabl_digg.skp tile_256x256_gpu c 49.92 43.06 +6.86 +13.7% -----

Patch Set 1 #

Patch Set 2 : Removed some cruft #

Total comments: 2

Patch Set 3 : Added unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -46 lines) Patch
M include/core/SkPath.h View 1 2 2 chunks +13 lines, -10 lines 0 comments Download
M include/gpu/GrAARectRenderer.h View 1 2 2 chunks +14 lines, -1 line 0 comments Download
M src/core/SkPath.cpp View 1 2 3 chunks +12 lines, -3 lines 0 comments Download
M src/effects/SkDashPathEffect.cpp View 1 2 3 chunks +7 lines, -0 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 2 5 chunks +55 lines, -14 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 3 chunks +67 lines, -10 lines 0 comments Download
M tests/PathTest.cpp View 1 2 3 chunks +29 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
robertphillips
7 years, 7 months ago (2013-05-16 14:07:54 UTC) #1
reed1
1. style nit on SkPath.h 2. unittest for the new call on path? https://codereview.chromium.org/15080010/diff/2001/include/core/SkPath.h File ...
7 years, 7 months ago (2013-05-16 14:13:20 UTC) #2
caryclark
lgtm (w/unit test as Mike says)
7 years, 7 months ago (2013-05-16 14:38:02 UTC) #3
bsalomon
ditto
7 years, 7 months ago (2013-05-16 14:54:08 UTC) #4
robertphillips
PTAL - piggy-backed direction-returning unit test on top of existing unit test. https://codereview.chromium.org/15080010/diff/2001/include/core/SkPath.h File include/core/SkPath.h ...
7 years, 7 months ago (2013-05-16 15:33:55 UTC) #5
reed1
lgtm
7 years, 7 months ago (2013-05-16 16:24:22 UTC) #6
Tom Hudson
Is there any reason we couldn't write something like this for CPU?
7 years, 7 months ago (2013-05-16 17:25:07 UTC) #7
robertphillips
Mike can correct me but I believe the raster path performs a 9-patch optimization in ...
7 years, 7 months ago (2013-05-16 17:45:29 UTC) #8
robertphillips
7 years, 7 months ago (2013-05-17 12:50:55 UTC) #9
Message was sent while issue was closed.
committed as r9175

Powered by Google App Engine
This is Rietveld 408576698