Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1507973005: Make "alpha only" be a property of GrTextureProducer (Closed)

Created:
5 years ago by bsalomon
Modified:
5 years ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@producernine
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make "alpha only" be a property of GrTextureProducer Committed: https://skia.googlesource.com/skia/+/f1ecd21bf6fd69953f78dd79502c7c9df92cdc9a

Patch Set 1 #

Patch Set 2 : fix unused var #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -86 lines) Patch
M src/gpu/GrImageIDTextureAdjuster.cpp View 4 chunks +19 lines, -5 lines 0 comments Download
M src/gpu/GrTextureParamsAdjuster.h View 4 chunks +13 lines, -8 lines 0 comments Download
M src/gpu/GrTextureParamsAdjuster.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 3 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 12 chunks +24 lines, -36 lines 0 comments Download
M src/gpu/SkGpuDevice_drawTexture.cpp View 4 chunks +5 lines, -6 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 2 chunks +2 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
bsalomon
5 years ago (2015-12-08 16:59:39 UTC) #2
robertphillips
lgtm
5 years ago (2015-12-08 17:11:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507973005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507973005/1
5 years ago (2015-12-09 22:04:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/4729) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
5 years ago (2015-12-09 22:05:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507973005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507973005/20001
5 years ago (2015-12-10 00:51:24 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-10 01:06:06 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f1ecd21bf6fd69953f78dd79502c7c9df92cdc9a

Powered by Google App Engine
This is Rietveld 408576698