Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1507903006: EDK: Remove mojo::platform::MessageLoopForIO and add PlatformHandleWatcher. (Closed)

Created:
5 years ago by viettrungluu
Modified:
5 years ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Remove mojo::platform::MessageLoopForIO and add PlatformHandleWatcher. Instead, factories for "MessageLoopForIOs" should produce a MessageLoop and (a pointer to) a PlatformHandleWatcher (which may be implemented by the same object). This is so when I make a factory for "I/O threads", it'll produce a "Thread" object, a TaskRunner, and a PlatformHandleWatcher. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/807d8ce0928fc1a49dd58c899aa5f6e1b6497073

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -59 lines) Patch
M mojo/edk/base_edk/platform_message_loop_for_io_impl.h View 4 chunks +16 lines, -5 lines 0 comments Download
M mojo/edk/base_edk/platform_message_loop_for_io_impl.cc View 2 chunks +67 lines, -0 lines 0 comments Download
M mojo/edk/base_edk/platform_message_loop_for_io_impl_unittest.cc View 2 chunks +52 lines, -0 lines 0 comments Download
M mojo/edk/base_edk/test_message_loops.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M mojo/edk/base_edk/test_message_loops_unittest.cc View 2 chunks +8 lines, -5 lines 1 comment Download
M mojo/edk/platform/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D mojo/edk/platform/message_loop_for_io.h View 1 chunk +0 lines, -36 lines 0 comments Download
A mojo/edk/platform/platform_handle_watcher.h View 1 chunk +67 lines, -0 lines 0 comments Download
M mojo/edk/platform/test_message_loops.h View 1 chunk +9 lines, -6 lines 0 comments Download
M mojo/edk/system/channel_manager_unittest.cc View 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
5 years ago (2015-12-08 23:18:27 UTC) #1
vardhan
lgtm https://codereview.chromium.org/1507903006/diff/1/mojo/edk/base_edk/test_message_loops_unittest.cc File mojo/edk/base_edk/test_message_loops_unittest.cc (right): https://codereview.chromium.org/1507903006/diff/1/mojo/edk/base_edk/test_message_loops_unittest.cc#newcode34 mojo/edk/base_edk/test_message_loops_unittest.cc:34: // TODO(vtl): Also test the watcher. :P
5 years ago (2015-12-09 00:18:27 UTC) #2
viettrungluu
5 years ago (2015-12-09 00:30:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
807d8ce0928fc1a49dd58c899aa5f6e1b6497073 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698