Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1266)

Unified Diff: mojo/edk/platform/test_message_loops.h

Issue 1507903006: EDK: Remove mojo::platform::MessageLoopForIO and add PlatformHandleWatcher. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/edk/platform/test_message_loops.h
diff --git a/mojo/edk/platform/test_message_loops.h b/mojo/edk/platform/test_message_loops.h
index e9b2749606b436932bf330b7a337fcdf5ccf16dc..afbf3e848e2cc7a285343a5e50692e733d093efc 100644
--- a/mojo/edk/platform/test_message_loops.h
+++ b/mojo/edk/platform/test_message_loops.h
@@ -14,17 +14,20 @@ namespace mojo {
namespace platform {
class MessageLoop;
-class MessageLoopForIO;
+class PlatformHandleWatcher;
namespace test {
-// Creates a basic |platform::MessageLoop|, to be used by tests. This must be
-// implemented by the embedder (if building tests that require it).
+// Creates a basic |MessageLoop|, to be used by tests. This must be implemented
+// by the embedder (if building tests that require it).
std::unique_ptr<MessageLoop> CreateTestMessageLoop();
-// Creates a basic |platform::MessageLoopForIO|, to be used by tests. This must
-// be implemented by the embedder (if building tests that require it).
-std::unique_ptr<MessageLoopForIO> CreateTestMessageLoopForIO();
+// Creates a basic |MessageLoop| that supports watching |PlatformHandle|s, to be
+// used by tests. This must be implemented by the embedder (if building tests
+// that require it). The "out" |PlatformHandleWatcher| is valid while the
+// returned |MessageLoop| is alive (and will watch handles while it is running).
+std::unique_ptr<MessageLoop> CreateTestMessageLoopForIO(
+ PlatformHandleWatcher** platform_handle_watcher);
} // namespace test
} // namespace platform

Powered by Google App Engine
This is Rietveld 408576698