Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 1507823002: Improve style of V8 API code (Closed)

Created:
5 years ago by Dan Ehrenberg
Modified:
5 years ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Improve style of V8 API code Fix some minor issues that the linter is complaining about R=jochen Committed: https://crrev.com/425983190a915d64db996e714b7e08991fc37b2f Cr-Commit-Position: refs/heads/master@{#32667}

Patch Set 1 #

Patch Set 2 : remove unused <string> include #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -35 lines) Patch
M include/v8.h View 4 chunks +8 lines, -6 lines 1 comment Download
M src/api.cc View 1 9 chunks +26 lines, -29 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507823002/1
5 years ago (2015-12-07 20:17:05 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-07 20:45:55 UTC) #4
Dan Ehrenberg
5 years ago (2015-12-07 21:46:54 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507823002/20001
5 years ago (2015-12-07 22:00:56 UTC) #7
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-12-07 22:12:03 UTC) #8
Michael Starzinger
https://codereview.chromium.org/1507823002/diff/20001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/1507823002/diff/20001/include/v8.h#newcode22 include/v8.h:22: #include <string> As discussed offline, this is most likely ...
5 years ago (2015-12-07 22:17:47 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-07 22:48:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507823002/20001
5 years ago (2015-12-07 23:31:02 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-07 23:34:35 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-07 23:34:54 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/425983190a915d64db996e714b7e08991fc37b2f
Cr-Commit-Position: refs/heads/master@{#32667}

Powered by Google App Engine
This is Rietveld 408576698