Chromium Code Reviews| Index: include/v8.h |
| diff --git a/include/v8.h b/include/v8.h |
| index a2c35f8415cb2d3a99b440c467be54759bf80934..3f58c09693c54c4329a4f1d6ff6eb4bed800246e 100644 |
| --- a/include/v8.h |
| +++ b/include/v8.h |
| @@ -12,13 +12,15 @@ |
| * For other documentation see http://code.google.com/apis/v8/ |
| */ |
| -#ifndef V8_H_ |
| -#define V8_H_ |
| +#ifndef INCLUDE_V8_H_ |
| +#define INCLUDE_V8_H_ |
| #include <stddef.h> |
| #include <stdint.h> |
| #include <stdio.h> |
| +#include <string> |
|
Michael Starzinger
2015/12/07 22:17:47
As discussed offline, this is most likely a false
|
| + |
| #include "v8-version.h" // NOLINT(build/include) |
| #include "v8config.h" // NOLINT(build/include) |
| @@ -2456,8 +2458,8 @@ class V8_EXPORT Symbol : public Name { |
| Local<Value> Name() const; |
| // Create a symbol. If name is not empty, it will be used as the description. |
| - static Local<Symbol> New( |
| - Isolate *isolate, Local<String> name = Local<String>()); |
| + static Local<Symbol> New(Isolate* isolate, |
| + Local<String> name = Local<String>()); |
| // Access global symbol registry. |
| // Note that symbols created this way are never collected, so |
| @@ -7171,7 +7173,7 @@ class Internals { |
| V8_INLINE static void SetEmbedderData(v8::Isolate* isolate, |
| uint32_t slot, |
| void* data) { |
| - uint8_t *addr = reinterpret_cast<uint8_t *>(isolate) + |
| + uint8_t* addr = reinterpret_cast<uint8_t*>(isolate) + |
| kIsolateEmbedderDataOffset + slot * kApiPointerSize; |
| *reinterpret_cast<void**>(addr) = data; |
| } |
| @@ -8474,4 +8476,4 @@ void V8::VisitHandlesForPartialDependence(Isolate* isolate, |
| #undef TYPE_CHECK |
| -#endif // V8_H_ |
| +#endif // INCLUDE_V8_H_ |