Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: components/page_load_metrics/browser/page_load_metrics_util.cc

Issue 1507813002: Don't log background navigations in StaleWhileRevalidateExperiment histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make EventOccurredInForeground take a PageLoadExtraInfo object. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/page_load_metrics/browser/page_load_metrics_util.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/page_load_metrics/browser/page_load_metrics_util.cc
diff --git a/components/page_load_metrics/browser/page_load_metrics_util.cc b/components/page_load_metrics/browser/page_load_metrics_util.cc
index 9b641e52d0778bed7a72b0b39b2e0bb507f6cc91..19436f3341098e2e21c35f15c3c5013a2dd3da6f 100644
--- a/components/page_load_metrics/browser/page_load_metrics_util.cc
+++ b/components/page_load_metrics/browser/page_load_metrics_util.cc
@@ -6,6 +6,7 @@
#include <algorithm>
+#include "components/page_load_metrics/browser/page_load_metrics_observer.h"
#include "components/page_load_metrics/common/page_load_timing.h"
namespace page_load_metrics {
@@ -18,5 +19,11 @@ base::TimeDelta GetFirstContentfulPaint(const PageLoadTiming& timing) {
return std::min(timing.first_text_paint, timing.first_image_paint);
}
-} // namespace page_load_metrics
+bool EventOccurredInForeground(const base::TimeDelta& event,
+ const PageLoadExtraInfo& info) {
+ return info.started_in_foreground && !event.is_zero() &&
+ (info.first_background_time.is_zero() ||
+ event < info.first_background_time);
+}
+} // namespace page_load_metrics
« no previous file with comments | « components/page_load_metrics/browser/page_load_metrics_util.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698