Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: components/page_load_metrics/browser/page_load_metrics_util.cc

Issue 1507813002: Don't log background navigations in StaleWhileRevalidateExperiment histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make EventOccurredInForeground take a PageLoadExtraInfo object. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/page_load_metrics/browser/page_load_metrics_util.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/page_load_metrics/browser/page_load_metrics_util.h" 5 #include "components/page_load_metrics/browser/page_load_metrics_util.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "components/page_load_metrics/browser/page_load_metrics_observer.h"
9 #include "components/page_load_metrics/common/page_load_timing.h" 10 #include "components/page_load_metrics/common/page_load_timing.h"
10 11
11 namespace page_load_metrics { 12 namespace page_load_metrics {
12 13
13 base::TimeDelta GetFirstContentfulPaint(const PageLoadTiming& timing) { 14 base::TimeDelta GetFirstContentfulPaint(const PageLoadTiming& timing) {
14 if (timing.first_text_paint.is_zero()) 15 if (timing.first_text_paint.is_zero())
15 return timing.first_image_paint; 16 return timing.first_image_paint;
16 if (timing.first_image_paint.is_zero()) 17 if (timing.first_image_paint.is_zero())
17 return timing.first_text_paint; 18 return timing.first_text_paint;
18 return std::min(timing.first_text_paint, timing.first_image_paint); 19 return std::min(timing.first_text_paint, timing.first_image_paint);
19 } 20 }
20 21
22 bool EventOccurredInForeground(const base::TimeDelta& event,
23 const PageLoadExtraInfo& info) {
24 return info.started_in_foreground && !event.is_zero() &&
25 (info.first_background_time.is_zero() ||
26 event < info.first_background_time);
27 }
28
21 } // namespace page_load_metrics 29 } // namespace page_load_metrics
22
OLDNEW
« no previous file with comments | « components/page_load_metrics/browser/page_load_metrics_util.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698