content/browser/presentation/presentation_service_impl.h - Issue 1507743005: [MediaRouter] Renames CloseRoute() to Terminate() and creates DetachRoute()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/presentation/presentation_service_impl.h

Issue 1507743005: [MediaRouter] Renames CloseRoute() to Terminate() and creates DetachRoute() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Forgot a call to DetachRoute! Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/router/presentation_service_delegate_impl.cc ('K') | « chrome/browser/ui/webui/media_router/media_router_ui.cc ('k') | content/browser/presentation/presentation_service_impl.cc » ('j') | extensions/renderer/resources/media_router_bindings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/presentation/presentation_service_impl.h

diff --git a/content/browser/presentation/presentation_service_impl.h b/content/browser/presentation/presentation_service_impl.h

index fc95d3f7adde311916436e07e3305ee3814aa3e7..e06a13f36a9b2da06a97dd1fef05049e292f52f2 100644

--- a/content/browser/presentation/presentation_service_impl.h

+++ b/content/browser/presentation/presentation_service_impl.h

@@ -163,12 +163,10 @@ class CONTENT_EXPORT PresentationServiceImpl

void SendSessionMessage(presentation::PresentationSessionInfoPtr session_info,

presentation::SessionMessagePtr session_message,

const SendMessageMojoCallback& callback) override;

- void CloseSession(

- const mojo::String& presentation_url,

- const mojo::String& presentation_id) override;

- void TerminateSession(

- const mojo::String& presentation_url,

- const mojo::String& presentation_id) override;

+ void CloseConnection(const mojo::String& presentation_url,

+ const mojo::String& presentation_id) override;

+ void Terminate(const mojo::String& presentation_url,

+ const mojo::String& presentation_id) override;

void ListenForSessionMessages(

presentation::PresentationSessionInfoPtr session) override;