extensions/renderer/resources/media_router_bindings.js - Issue 1507743005: [MediaRouter] Renames CloseRoute() to Terminate() and creates DetachRoute()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/media_router_bindings.js

Issue 1507743005: [MediaRouter] Renames CloseRoute() to Terminate() and creates DetachRoute() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Forgot a call to DetachRoute! Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/router/presentation_service_delegate_impl.cc ('K') | « content/renderer/presentation/presentation_dispatcher.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/resources/media_router_bindings.js

diff --git a/extensions/renderer/resources/media_router_bindings.js b/extensions/renderer/resources/media_router_bindings.js

index 7bf09d3bf9ab598f5fdd89024c20877802727f60..1fcfe3592b0b6530f0329c2d97bcd9eeb8a166f5 100644

--- a/extensions/renderer/resources/media_router_bindings.js

+++ b/extensions/renderer/resources/media_router_bindings.js

@@ -326,7 +326,7 @@ define('media_router_bindings', [

/**

* @type {function(string)}

- this.closeRoute = null;

+ this.terminateRoute = null;

/**

* @type {function(string)}

@@ -362,7 +362,7 @@ define('media_router_bindings', [

/**

* @type {function(string)}

- this.onPresentationSessionDetached = null;

+ this.detachRoute = null;

/**

* @type {function()}

@@ -414,8 +414,8 @@ define('media_router_bindings', [

'sendRouteBinaryMessage',

'listenForRouteMessages',

'stopListeningForRouteMessages',

- 'onPresentationSessionDetached',

- 'closeRoute',

+ 'detachRoute',

+ 'terminateRoute',

'joinRoute',

'createRoute',

'stopObservingMediaSinks',