chrome/browser/media/router/presentation_service_delegate_impl.h - Issue 1507743005: [MediaRouter] Renames CloseRoute() to Terminate() and creates DetachRoute()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/presentation_service_delegate_impl.h

Issue 1507743005: [MediaRouter] Renames CloseRoute() to Terminate() and creates DetachRoute() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Forgot a call to DetachRoute! Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/router/media_router_metrics.h ('K') | « chrome/browser/media/router/mock_media_router.h ('k') | chrome/browser/media/router/presentation_service_delegate_impl.cc » ('j') | chrome/browser/media/router/presentation_service_delegate_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/presentation_service_delegate_impl.h

diff --git a/chrome/browser/media/router/presentation_service_delegate_impl.h b/chrome/browser/media/router/presentation_service_delegate_impl.h

index 2209e1ad279a366060faaf4c1a07c2918df0cb3b..b87ceeb4fd0c7c7e4c3d3330bcf1ed4c2a70d336 100644

--- a/chrome/browser/media/router/presentation_service_delegate_impl.h

+++ b/chrome/browser/media/router/presentation_service_delegate_impl.h

@@ -107,12 +107,12 @@ class PresentationServiceDelegateImpl

const std::string& presentation_id,

const content::PresentationSessionStartedCallback& success_cb,

const content::PresentationSessionErrorCallback& error_cb) override;

- void CloseSession(int render_process_id,

- int render_frame_id,

- const std::string& presentation_id) override;

- void TerminateSession(int render_process_id,

- int render_frame_id,

- const std::string& presentation_id) override;

+ void CloseConnection(int render_process_id,

+ int render_frame_id,

+ const std::string& presentation_id) override;

+ void Terminate(int render_process_id,

+ int render_frame_id,

+ const std::string& presentation_id) override;

void ListenForSessionMessages(

int render_process_id,

int render_frame_id,