chrome/browser/media/router/media_router_metrics.h - Issue 1507743005: [MediaRouter] Renames CloseRoute() to Terminate() and creates DetachRoute()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/media_router_metrics.h

Issue 1507743005: [MediaRouter] Renames CloseRoute() to Terminate() and creates DetachRoute() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Forgot a call to DetachRoute! Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/router/media_router.mojom ('K') | « chrome/browser/media/router/media_router.mojom ('k') | chrome/browser/media/router/media_router_mojo_impl.h » ('j') | chrome/browser/media/router/presentation_service_delegate_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/media_router_metrics.h

diff --git a/chrome/browser/media/router/media_router_metrics.h b/chrome/browser/media/router/media_router_metrics.h

index fddfd45884c5ead60a46990ce5a1e1a8219bc4d4..824a00b82de65d19c5aa8e686a7fcf0887bb51df 100644

--- a/chrome/browser/media/router/media_router_metrics.h

+++ b/chrome/browser/media/router/media_router_metrics.h

@@ -26,10 +26,10 @@ enum class MediaRouterDialogOpenOrigin {

enum class MediaRouteProviderWakeReason {

CREATE_ROUTE = 0,

JOIN_ROUTE = 1,

- CLOSE_ROUTE = 2,

+ TERMINATE_ROUTE = 2,

SEND_SESSION_MESSAGE = 3,

SEND_SESSION_BINARY_MESSAGE = 4,

- PRESENTATION_SESSION_DETACHED = 5,

+ DETACH_ROUTE = 5,

mlamouri (slow - plz ping) 2015/12/10 15:39:51 open question: would there be a benefit in trying

mark a. foltz 2015/12/10 23:46:48 I think for now we should be able to get a good es

START_OBSERVING_MEDIA_SINKS = 6,

STOP_OBSERVING_MEDIA_SINKS = 7,

START_OBSERVING_MEDIA_ROUTES = 8,