Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1507683010: Fix crashing in CFWL_CheckBox::Initialize() (Closed)

Created:
5 years ago by jun_fang
Modified:
5 years ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M xfa/src/fwl/src/lightwidget/checkbox.cpp View 1 chunk +2 lines, -6 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
jun_fang
Hi Tom and Lei, Please start to review this CL. Thanks! https://codereview.chromium.org/1507683010/diff/1/xfa/src/fwl/src/lightwidget/checkbox.cpp File xfa/src/fwl/src/lightwidget/checkbox.cpp (left): ...
5 years ago (2015-12-10 08:43:19 UTC) #2
Tom Sepez
LGTM. I think this was originally right, but I botched it. Thanks.
5 years ago (2015-12-10 17:41:34 UTC) #3
jun_fang
5 years ago (2015-12-11 02:31:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c7c3f124fb4ece9a1e09ef16058c2f51947bf714 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698