Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1661)

Unified Diff: xfa/src/fwl/src/lightwidget/checkbox.cpp

Issue 1507683010: Fix crashing in CFWL_CheckBox::Initialize() (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/src/fwl/src/lightwidget/checkbox.cpp
diff --git a/xfa/src/fwl/src/lightwidget/checkbox.cpp b/xfa/src/fwl/src/lightwidget/checkbox.cpp
index a9ae80f5333b1a1e0d2e99deb4ed9d9ee3f6216e..91dc63af7554a8cc019cedaed17b5407fcd87a55 100644
--- a/xfa/src/fwl/src/lightwidget/checkbox.cpp
+++ b/xfa/src/fwl/src/lightwidget/checkbox.cpp
@@ -14,12 +14,8 @@ FWL_ERR CFWL_CheckBox::Initialize(const CFWL_WidgetProperties* pProperties) {
if (pProperties) {
*m_pProperties = *pProperties;
}
- CFWL_WidgetImpProperties prop =
- m_pProperties->MakeWidgetImpProperties(&m_checkboxData);
- prop.m_pParent = m_pProperties->m_pParent->GetWidget();
- prop.m_pOwner = m_pProperties->m_pOwner->GetWidget();
jun_fang 2015/12/10 08:43:19 These two assignments were in the helper function.
- nonstd::unique_ptr<IFWL_CheckBox> pCheckBox(
- IFWL_CheckBox::Create(prop, nullptr));
+ nonstd::unique_ptr<IFWL_CheckBox> pCheckBox(IFWL_CheckBox::Create(
+ m_pProperties->MakeWidgetImpProperties(&m_checkboxData), nullptr));
FWL_ERR ret = pCheckBox->Initialize();
if (ret != FWL_ERR_Succeeded) {
return ret;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698